Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manual: move the short object copy notation to core chapters #2232

Merged
merged 1 commit into from Feb 4, 2019

Conversation

Projects
None yet
2 participants
@Octachron
Copy link
Contributor

commented Feb 1, 2019

This PR proposes to move the short object copy notation,

class c = object
   val x = []
   method m x = {< x >}
end

to the core part of the manual. This move seemed reasonable to me: this is a small enhancement of an existing syntax, introduced in 4.03, and quite similar to the record notation (which is now explained during the introduction of records in the first chapter).

@gasche

gasche approved these changes Feb 1, 2019

Copy link
Member

left a comment

This looks fine to me. (I'll let you decide when/how to merge.)

@Octachron

This comment has been minimized.

Copy link
Contributor Author

commented Feb 3, 2019

Do you think I should cherry-pick the change to 4.08 ?

@gasche

This comment has been minimized.

Copy link
Member

commented Feb 3, 2019

Yes, I think it would be fine to do so. The manual is one of the few remaining area where we have more release-management leeway than other parts of the codebase.

@Octachron Octachron force-pushed the Octachron:nme_short_object_copy branch from b59b831 to 672b75e Feb 4, 2019

@Octachron Octachron merged commit 0e3f15c into ocaml:trunk Feb 4, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Octachron

This comment has been minimized.

Copy link
Contributor Author

commented Feb 4, 2019

Cherry-picked as e9f493f .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.