Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Constify "identifier" in struct custom_operations #2240
Because otherwise it is not possible to initialize it with a constant
No tests seams to be more annoyed by this change but of course it is
xavierleroy left a comment
Looks good to me. I can't think of any code that could want to change the
Looks like a rebase is needed to solve the conflict on Changes.
Because otherwise it is not possible to initialize it with a constant C string when compiling with a C++ compiler without getting a warning: ISO C++11 does not allow conversion from string literal to 'char *' [-Wwritable-strings] No tests seams to be more annoyed by this change but of course it is always possible that some code in the wild relies on this field to be non-const. This is indeed an API change, although a trivial one.