Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fatal error compiling module aliases #2252

Merged
merged 2 commits into from Feb 21, 2019

Conversation

Projects
None yet
2 participants
@lpw25
Copy link
Contributor

commented Feb 15, 2019

Fixes MPR#7920. Now that module aliases can be properly absent they need to be treated specially by field_of_str in translmod.ml,

lpw25 added some commits Feb 15, 2019

@lpw25

This comment has been minimized.

Copy link
Contributor Author

commented Feb 15, 2019

I've attached this to #1610 in the Changes file since it was really just an oversight from that PR and it hasn't been released yet other than in the beta.

@lpw25 lpw25 added the bug label Feb 20, 2019

@gasche

gasche approved these changes Feb 20, 2019

Copy link
Member

left a comment

I'm not an expert of the codebase, but the patch looks correct, @lpw25 wrote the original change (so there is not much risk in trusting the process one step further), and there is a passing testsuite in the patch that was crashing beforehand.

@lpw25 lpw25 merged commit e0a3531 into ocaml:trunk Feb 21, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lpw25

This comment has been minimized.

Copy link
Contributor Author

commented Feb 21, 2019

Cherry-picked onto 4.08 as b1d1cbb..38abeff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.