Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPR#7918: fix 4.08+dev regression, object files would remain after build error #2257

Merged
merged 2 commits into from Feb 26, 2019

Conversation

Projects
None yet
2 participants
@gasche
Copy link
Member

commented Feb 19, 2019

Fixes MPR#7918.

If approved, this should go into 4.08 -- it's a regression in 4.08+dev.

It would be nice to write a regression test, but I haven't had the time to do so yet.

@gasche

This comment has been minimized.

Copy link
Member Author

commented Feb 19, 2019

Now with a regression test.

@gasche

This comment has been minimized.

Copy link
Member Author

commented Feb 24, 2019

I would need a reviewer for this one. @Drup, @alainfrisch, @nojb?

@nojb

nojb approved these changes Feb 26, 2019

Copy link
Contributor

left a comment

LGTM, modulo a stylistic issue and some check-typo errors.

Show resolved Hide resolved driver/compile_common.ml Outdated

@gasche gasche force-pushed the gasche:mpr7918 branch from fe03f43 to 9abdd66 Feb 26, 2019

@gasche gasche merged commit 39f8c80 into ocaml:trunk Feb 26, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gasche

This comment has been minimized.

Copy link
Member Author

commented Feb 26, 2019

(Testing this on 4.08, and cherry-picking if it works.)

gasche added a commit that referenced this pull request Feb 26, 2019

Merge pull request #2257 from gasche/mpr7918
MPR#7918: fix 4.08+dev regression, object files would remain after build error

(cherry picked from commit 39f8c80)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.