Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPR#7923 1/2 - fix bootstrapped flexdll #2259

Merged
merged 1 commit into from Feb 28, 2019

Conversation

Projects
None yet
2 participants
@dra27
Copy link
Contributor

commented Feb 21, 2019

The bootstrapped build for flexdll works, but owing to the refactoring of Makefile and utils/Makefile in #2093, Config.flexdll_dirs is not correctly generated so the resulting compiler will fail:

C:\Users\DRA\Documents>ocamlopt -o hello.exe hello.ml
** Fatal error: Cannot find file "flexdll_msvc64.obj"
File "caml_startup", line 1:
Error: Error during linking

This isn't picked up during the build because the FlexDLL objects are (correctly) taken from the submodule directory.

This should go into 4.08 before beta2.

Move FLEXDLL_DIR definition to utils/Makefile
Missed in d68e0e2. Fixes second part of MPR#7923.

@dra27 dra27 added this to the 4.08 milestone Feb 21, 2019

@dra27 dra27 added the bug label Feb 21, 2019

@shindere

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2019

@dra27

This comment has been minimized.

Copy link
Contributor Author

commented Feb 28, 2019

That's correct - FLEXDLL_DIR is just +flexdll - i.e. it's an OCaml-style include directory. It's not used in the build system, since +flexdll refers to an installation directory.

You are also correct that this will be configures job - I am presently working on a comprehensive flexlink update to configure.ac (full detection, probing, and enabling of the bootstrap mode) which is just about finished, but needs testing in a gazillion different environment set-ups!

@dra27 dra27 force-pushed the dra27:fix-flexdll-bootstrap branch from 2231265 to f77d760 Feb 28, 2019

@shindere shindere merged commit 8831395 into ocaml:trunk Feb 28, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@shindere

This comment has been minimized.

Copy link
Contributor

commented Feb 28, 2019

@dra27

This comment has been minimized.

Copy link
Contributor Author

commented Feb 28, 2019

Thanks, @shindere - this does need to go in 4.08, yes.

shindere added a commit that referenced this pull request Feb 28, 2019

Move FLEXDLL_DIR definition to utils/Makefile (#2259)
Missed in d68e0e2. Fixes second part of MPR#7923.
@shindere

This comment has been minimized.

Copy link
Contributor

commented Feb 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.