Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CFA-related directives in x86-64 backend #2300

Open
wants to merge 1 commit into
base: trunk
from

Conversation

@mshinwell
Copy link
Contributor

commented Mar 7, 2019

I believe that some of the CFA adjustments in the x86-64 backend aren't correct at the moment. I had a fair amount of trouble getting this right, so that variables on the stack appear correctly in the debugger at all times, but I think it's ok now. The reference for some of this business is the x86-64 ABI document which is available on the web in various places.

There used to be another CFA-related error in the same backend, but it was fixed in #2237 I think.

I have introduced some helper functions to minimise the possibility of getting the CFA offset wrong at the same time. These simplify the code.

We will need to check the other backends for similar problems, but let's do that once the gdb support is merged and working on x86-64.

@mshinwell

This comment has been minimized.

Copy link
Contributor Author

commented Mar 7, 2019

@chambart Are you able to look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.