Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Hint on type error on int operators #2307
Add an hint when using
The hint is only enabled on
I made a small refactor of the
gasche left a comment
I believe that the code is correct, and the feature is a user-improvement. The patch was a bit painful to review (the refactorings mixed with the actual feature makes it a bit unpleasant; in particular, 717ad28 could be split in changes to parameter-passing and the actual feature), but the tests give me a fair amount of confidence.
I spotted a few readability improvements that you could make.
One thing that I think is not optimal is that the three error-hint logics are all performed in different ways at the point we call
It's a shame that we have these three different passing protocol. I think a nicer API would be something like