Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
More debugging information in Cmm terms #2308
Following on from GPR#851 and GPR#873, this pull request further enhances debugging information in Cmm terms. This was driven both by manually examining the debugger's behaviour and also by a report received from a user regarding substandard DWARF location information.
Some parts of this pull request will hook into future pull requests, in particular:
There was a missing copyright header on the AFL instrumentation interface file which I took the liberty of adding here along with the other changes.
I strongly recommend using
It looks like some changes to
Apart from that, this looks good to me. It's an almost entirely mechanical change.
Is it definitely OK to change all of the temporary variable names from
For the record: as the author of
Ah, you are right, I forgot to do the other architectures. Will do that this morning.
Regarding the identifiers: I should have pointed out this change specifically in the comment above, my apologies. Adding the asterisks follows an existing convention in the compiler and ensures that internally-generated variables can be identified. (I would like to have a proper flag on
I don't think any of the Cmm variable names with asterisks will be lifted to symbols, but presumably names with asterisks from the front end might be. In this case I don't think there will be a problem because we escape symbols before emitting them into assembly files.