Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 32-bit build on OpenIndiana #525

Merged
merged 1 commit into from Oct 5, 2016

Conversation

Projects
None yet
4 participants
@avsej
Copy link
Contributor

commented Mar 25, 2016

No description provided.

@avsej avsej force-pushed the avsej:solaris-build branch from 739dd15 to e2b7751 Mar 25, 2016

@damiendoligez damiendoligez added this to the 4.04 milestone Mar 31, 2016

@gasche

This comment has been minimized.

Copy link
Member

commented Jun 26, 2016

I missed your pull request so @lijunsong and myself reimplemented a part of it in #588 (the XOPEN_SOURCE change) -- sorry about that. The part of your proposal that remain is the aspp change, but my understanding of MPR#6831 is that, at the time at least, as -P was still considered to be the correct practice on OpenIndiana. Why the change now, is it only for more recent (or older) OpenIndiana versions?

@avsej

This comment has been minimized.

Copy link
Contributor Author

commented Jun 27, 2016

The OpenIndiana tries not to use sun compiler, and not to mix with gnu toolchain. I've tested on recent distribution, because it is rolling release

@mshinwell

This comment has been minimized.

Copy link
Contributor

commented Sep 7, 2016

@damiendoligez Should this be considered for 4.04?

@damiendoligez

This comment has been minimized.

Copy link
Member

commented Sep 29, 2016

I'm OK to merge this into 4.04.

@gasche

This comment has been minimized.

Copy link
Member

commented Sep 30, 2016

(I don't have time to merge.)

@damiendoligez

This comment has been minimized.

Copy link
Member

commented Oct 4, 2016

@avsej Could you add an entry to the Changes file?

@avsej avsej force-pushed the avsej:solaris-build branch from e2b7751 to b466873 Oct 4, 2016

@avsej

This comment has been minimized.

Copy link
Contributor Author

commented Oct 4, 2016

@damiendoligez damiendoligez merged commit fd58d73 into ocaml:trunk Oct 5, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@avsej avsej deleted the avsej:solaris-build branch Oct 5, 2016

@gasche

This comment has been minimized.

Copy link
Member

commented Nov 3, 2016

I think that this was not merged in 4.04, so we should probably do it now.

damiendoligez added a commit that referenced this pull request Nov 4, 2016

@damiendoligez

This comment has been minimized.

Copy link
Member

commented Nov 4, 2016

cherry-picked to 4.04 (commit 2b38943)

camlspotter pushed a commit to camlspotter/ocaml that referenced this pull request Oct 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.