Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten symbol names of anonymous functions in Flambda mode #8507

Merged
merged 2 commits into from Mar 18, 2019

Conversation

@mshinwell
Copy link
Contributor

commented Mar 15, 2019

Precheck fails on #2268 not only because of #8506 but also because of some excessively long symbol names. These cause trouble on Windows platforms where there is a length limit on such things. The symbol names correspond to anonymous functions, whose names for convenience are equipped with the source filename and location. I have changed these names in this patch to strip any directory names, which should reduce problems in this area with very deeply nested directory structures and/or use of -absname.

In the future, the actual names of symbols won't really be relevant any more, since the DWARF information will enable debuggers and other tools to reconstruct proper names even for anonymous functions. (Furthermore, I believe the current namespacing proposals of @lpw25 are going to yield symbols that to a first approximation are just hashes.)

I will add a Changes entry to this in due course, since this is user-visible.

@mshinwell mshinwell requested a review from chambart Mar 15, 2019
@nojb

This comment has been minimized.

Copy link
Contributor

commented Mar 15, 2019

I think this also fixes #7895

@mshinwell

This comment has been minimized.

Copy link
Contributor Author

commented Mar 15, 2019

Most probably, yes.

@mshinwell mshinwell force-pushed the mshinwell:flambda_name_mangling branch from 74ae615 to c843e2d Mar 18, 2019
@mshinwell

This comment has been minimized.

Copy link
Contributor Author

commented Mar 18, 2019

@nojb Actually, are you in a position to approve this? I think it can be merged without waiting for CI again, the change is local and the only CI failure was on Changes.

@dra27
dra27 approved these changes Mar 18, 2019
Copy link
Contributor

left a comment

This definitely solves #7895 too

@nojb
nojb approved these changes Mar 18, 2019
Copy link
Contributor

left a comment

LGTM

@nojb nojb merged commit db1e59d into ocaml:trunk Mar 18, 2019
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.