Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some unused configure tests. #8533

Merged
merged 1 commit into from Mar 21, 2019

Conversation

Projects
None yet
3 participants
@stedolan
Copy link
Contributor

commented Mar 20, 2019

Removes a few tests that are no longer needed by the build, but still done by configure.

  • HAS_ASYNC_IO - was only used by Graphics, so not needed after #2318
  • HAS_DUP2 - last use removed by #650
  • HAS_GETPRIORITY - last use removed by 7ae8be5
  • HAS_SIGSETMASK - last use removed by 51c55b2

(the HAS_ASYNC_IO test was particularly slow, so this speeds up configure a bit)

@dra27

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

config.h is user-facing, so I think this warrants a starred Changes entry.

Have you done a check on opam-repository to see if these are used by any library code?

@stedolan

This comment has been minimized.

Copy link
Contributor Author

commented Mar 21, 2019

Changes entry added. The only occurrences of these strings in OPAM are definitions in copies of s.h. There aren't any uses.

@stedolan stedolan force-pushed the stedolan:dead-configure-checks branch from 4a3abf2 to a5bb609 Mar 21, 2019

@dra27

dra27 approved these changes Mar 21, 2019

Copy link
Contributor

left a comment

Seems good to me, if @shindere agrees?

@shindere

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

@shindere

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

@stedolan stedolan force-pushed the stedolan:dead-configure-checks branch from a5bb609 to 95a8e80 Mar 21, 2019

@stedolan

This comment has been minimized.

Copy link
Contributor Author

commented Mar 21, 2019

I missed the HAS_DUP2 in s-nt.h! Deleted now.

@shindere shindere merged commit 58ef730 into ocaml:trunk Mar 21, 2019

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@shindere

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

@stedolan

This comment has been minimized.

Copy link
Contributor Author

commented Mar 21, 2019

Thanks! No, I don't see any reason to cherry-pick this to 4.08.

@stedolan stedolan deleted the stedolan:dead-configure-checks branch Mar 21, 2019

@stedolan

This comment has been minimized.

Copy link
Contributor Author

commented Mar 21, 2019

(In fact, it would break 4.08 to merge this! HAS_ASYNC_IO is used by Graphics, which is part of 4.08 but gone from trunk)

@shindere

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.