Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8550: Soundness issue with class generalization #8552

Merged
merged 8 commits into from Apr 9, 2019

Conversation

Projects
None yet
3 participants
@garrigue
Copy link
Contributor

commented Mar 28, 2019

Fix #8550 by replacing use of generalize_structure by modal iteration in generalize_expansive.

garrigue added some commits Mar 28, 2019

garrigue added some commits Mar 28, 2019

Show resolved Hide resolved typing/ctype.ml

garrigue added some commits Mar 28, 2019

@trefis

trefis approved these changes Apr 8, 2019

Copy link
Contributor

left a comment

Some minor stylistic comments, but otherwise this seems correct.

PS: given the state of the history, the commits should be squashed before/when merging.

Show resolved Hide resolved typing/ctype.ml Outdated
Show resolved Hide resolved typing/ctype.ml Outdated

garrigue added some commits Apr 9, 2019

@garrigue garrigue merged commit d32550f into ocaml:trunk Apr 9, 2019

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

garrigue added a commit that referenced this pull request Apr 9, 2019

Fix #8550: Soundness issue with class generalization (#8552)
* also rename generalize_expansive -> lower_contravariant
@garrigue

This comment has been minimized.

Copy link
Contributor Author

commented Apr 9, 2019

Cherry-picked in 4.08 as 409ba43.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.