Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix #7851 by checking type declaration coherence for recursive modules #8570
I suppose that a really robust solution to #7851 would be to fully check the wellformedness of signatures, but in the mid-time a simpler solution is to check the coherence of type declarations for recursive modules.
I mark this as consider for release, but it is probably not as urgent as #8552; as explained in #7851, this is a very old bug, and triggering it is not so easy. Yet, if we could have it in 4.08 this would be one soundness bug less!
Since the change is a bit light-headed, it would be a good idea to test this on a large code base with many recursive modules, if this happens to exist.