Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Add opam files to allow pinning #8604
On Fri, Apr 12, 2019 at 12:02 PM Gabriel Scherer ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In Changes <#8604 (comment)>: > @@ -582,6 +582,9 @@ OCaml 4.08.0 * GPR#8533: Remove some unused configure tests (Stephen Dolan, review by David Allsopp and Sébastien Hinderer) +- GPR#2207,#8604: Add opam files to allow pinning + (Leo White, Greta Yorsh) @gretay-js <https://github.com/gretay-js> please include Gabriel Radanne as a reviewer and I'll merge. Thanks both (and Leo) for the work! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#8604 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Aq68g1jaK73BLj8zGO3fevYzGwUx174Zks5vgGfjgaJpZM4cmmLZ> .
Yes, as far as I understand, but I am not sure about the procedure for updating opam repositories of ocaml vs release, so I haven't submitted any pull requests for updating https://github.com/ocaml/opam-repository/tree/master/packages/ocaml. It's just one file which I attached to this PR.…
On Fri, Apr 12, 2019 at 1:05 PM Gabriel Scherer ***@***.***> wrote: I just merged, and this went into the 4.08 branch. If I understand correctly, I should update the version to 4.09 to cherry-pick in trunk, but this also requires adding a 4.09 version in opam-repository or using ocaml-beta-repository in the meantime. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#8604 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Aq68g4egTiEhvMLArBeRHdkd7ACoZhvNks5vgHZ1gaJpZM4cmmLZ> .
Note that the ocaml-variants package on trunk doesn't want updating at release it wants updating at branch time cf #2207 (comment).
It's always OK to have
So, when we branch 4.09,
referenced this pull request
Apr 15, 2019
@dra27 Could we maybe revisit the decision to not include an
Is there any actual harm in keeping a local copy in the distribution? Maybe with a script to update the versions in it based on the VERSION file so it is easy to fix when things are changed (or even to check in CI that these things are in sync).