Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LACKS_SANE_NAN and LACKS_VCSPRINTF. #8607

Merged
merged 1 commit into from Apr 16, 2019

Conversation

@stedolan
Copy link
Contributor

commented Apr 10, 2019

These were present only for MSVC 2002, which is no longer supported (I think? @dra27 ?)

@stedolan stedolan requested a review from dra27 Apr 10, 2019
@nojb
nojb approved these changes Apr 12, 2019
Copy link
Contributor

left a comment

Thanks, nice cleanup! Note that this was for pre-MSVC 2002 compilers, so the Changes entry needs to be adjusted.

Changes Outdated
@@ -120,6 +120,9 @@ Working version
* #2293: Constify "caml_named_value"
(Stephen Dolan, review by Xavier Leroy)

- #???: Remove obsolete macros for MSVC 2002 support

This comment has been minimized.

Copy link
@nojb

nojb Apr 12, 2019

Contributor
  • Insert PR number
  • s/MSVC 2002/pre-MSVC 2002/
@nojb

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2019

BTW, README.win32.adoc lists VS 2005 as minimum supported version.

@dra27

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2019

I thought these were to do with runtime, not compiler... can I have a chance to check when not about to board a flight? 🙂

@dra27

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2019

Oh no, I’m thinking of something else... go for it!

@dra27

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2019

This was originally the product of some museum work, for the amused - see #384

These were present only for MSVC 2002, which is no longer supported.
@stedolan stedolan force-pushed the stedolan:sane-nan branch from 5a34239 to 5b12eb5 Apr 15, 2019
@stedolan

This comment has been minimized.

Copy link
Contributor Author

commented Apr 15, 2019

Thanks! I've updated the Changes entry.

@nojb nojb merged commit 51edd51 into ocaml:trunk Apr 16, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.