Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
configure: fix libunwind and spacetime support #8673
Damien Doligez (2019/05/16 04:55 -0700):
IIUC, this piece of code means that, if I pass a value for `--with-libunwind` it will be taken as a prefix for the `include` and `lib` directories. For example if I pass "no" or "true"...
Well "true" would indeed (wrongly) be interpreted as a prefix, but in practice I think that will not happen. The "no" case is delt iwth, see lines 1523 and 1524 of configure.ac: ```shell AS_IF([test x"$with_libunwind" = "xno"], [AC_MSG_RESULT([disabled])], ``` Remember that passing `--without-unwindlib` to configure will be translated by assigning the "no" value to the `with_unwindlib` variable. Also, this approach is both faithful to the way the former configure script was working and to what is described in the autoconf documentation.
Is this really needed?
Well we could also ignore the argument to this option, that's something I considered. But again, that's how the old configure script was doing so why not preserve that, and it lets people use only one option in the (probably most frequent) case where header and library files are uner the lib/ and include/ subdirectories of a common directory.
May 20, 2019
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews.