Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop talking about Pervasives in core library documentation #8757

Closed
wants to merge 4 commits into from

Conversation

@nobrowser
Copy link
Contributor

commented Jun 21, 2019

Since Pervasives is now just a deprecated alias for Stdlib, the Manual should stop mentioning it as a real module.

Copy link
Contributor

left a comment

Thanks - I’d change the description of the change, but the change itself is of course correct.

@@ -295,6 +295,9 @@ OCaml 4.09.0

### Manual and documentation:

- #8757: Stop talking about Pervasives in core library documentation.

This comment has been minimized.

Copy link
@dra27

dra27 Jun 21, 2019

Contributor
Suggested change
- #8757: Stop talking about Pervasives in core library documentation.
- #8757: Rename Pervasives to Stdlib in core library documentation.
dra27 added 2 commits Jun 21, 2019
Pervasives.input has never been a primitive (it was always unsafe_input)
- string_of_int has the benefit of being declared external.
@dra27

This comment has been minimized.

Copy link
Contributor

commented Jun 21, 2019

I pushed a commit with a few other renames and, while there, spotted that the use of input as an example in the C chapter of the manual was a bit limited. This all seems good for 4.09 as well, being documentation fixes only.

@nobrowser

This comment has been minimized.

Copy link
Contributor Author

commented Jun 21, 2019

Thanks @dra27 , that scratches my itch thoroughly.

@nobrowser nobrowser closed this Jun 21, 2019
@nobrowser nobrowser deleted the nobrowser:no-pervasisves-in-refman branch Jun 21, 2019
@pmetzger

This comment has been minimized.

Copy link
Member

commented Jun 22, 2019

I'm confused, did this get closed without being merged?

@nobrowser

This comment has been minimized.

Copy link
Contributor Author

commented Jun 22, 2019

I'm confused, did this get closed without being merged?

I thought @dra27 said he pushed a commit which included my suggestions plus other changes. Have I misunderstood him?

@nobrowser nobrowser restored the nobrowser:no-pervasisves-in-refman branch Jun 22, 2019
@dbuenzli

This comment has been minimized.

Copy link
Contributor

commented Jun 22, 2019

I thought @dra27 said he pushed a commit which included my suggestions plus other changes. Have I misunderstood him?

Yes he added them on you branch (see above) but he didn't merge the PR.

@pmetzger

This comment has been minimized.

Copy link
Member

commented Jun 22, 2019

Gotcha.

@dra27

This comment has been minimized.

Copy link
Contributor

commented Jun 23, 2019

trunk: 466950b
4.08: d44685b
4.09: e9f72e5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.