Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes in configure.ac #8830

Merged
merged 3 commits into from Jul 30, 2019

Conversation

@glondu
Copy link
Contributor

commented Jul 25, 2019

No description provided.

@dra27

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2019

precheck #291 - I'm suspicious the host_alias change may affect Windows.

@dra27

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2019

Wrong suspicion on my part - the Windows parts do use ac_tool_prefix.

Is ad56983 fixing an actual build failure (I'm trying to weigh up the severity, given that 4.08.1 is at RC2 and the original author of the line is on vacation, so I can't check if there's a subtle and uncommented reason for its being wrong!)

@glondu

This comment has been minimized.

Copy link
Contributor Author

commented Jul 25, 2019

Is ad56983 fixing an actual build failure

Yes, when building after configuring with --host x86_64-linux-gnu.

@gasche

This comment has been minimized.

Copy link
Member

commented Jul 25, 2019

I can reproduce the failure on my machine, using the setting --host x86_64-pc-linux-gnu that seems to be the auto-detected default here:

$ make world.opt
[...]
gcc -c -O2 -fno-strict-aliasing -fwrapv -Wall -Werror -fno-tree-vrp -g -D_FILE_OFFSET_BITS=64 -D_REENTRANT -DCAML_NAME_SPACE  -DOCAML_STDLIB_DIR='"/usr/local/lib/ocaml"'  -DNATIVE_CODE -DTARGET_amd64 -DMODEL_default -DSYS_linux   -o bigarray_n.o bigarray.c
x86_64-pc-linux-gnu-gcc -c -DSYS_linux -I../runtime -DMODEL_default -o amd64.o amd64.S || \
{ echo "If your assembler produced syntax errors, it is probably";\
          echo "unhappy with the preprocessor. Check your assembler, or";\
          echo "try producing amd64.o by hand.";\
          exit 2; }
/bin/sh: x86_64-pc-linux-gnu-gcc: command not found
If your assembler produced syntax errors, it is probably
unhappy with the preprocessor. Check your assembler, or
try producing amd64.o by hand.

This does look like something that we want to include in 4.08.1; I'll discuss this with @Octachron but that is our current consensus.

@gasche

This comment has been minimized.

Copy link
Member

commented Jul 25, 2019

(If we do merge this and do another release-candidate, we might as well grab #8826 as well to get rid of it.)

@glondu, I'm assuming that you spotted this thanks to some magical and useful Debian testing infrastructure. Do you have other reports coming, or do you know that there are no further issues coming up?

@dra27

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2019

@gasche

This comment has been minimized.

Copy link
Member

commented Jul 25, 2019

@glondu could you include a Changes entry?

@glondu

This comment has been minimized.

Copy link
Contributor Author

commented Jul 25, 2019

Do you have other reports coming, or do you know that there are no further issues coming up?

Yes, there is at least this patch that I would like to see merged upstream. It fixes FTBFS on kfreebsd-i386.

FYI, you can have a look at our build logs for 4.08.0 (+ some patches). As you can see, there are (at least) 3 failures. I've still not investigated the kfreebsd-amd64 failure, I will probably "fix" powerpc and x32 by disabling the native compiler there.

glondu added some commits Jul 10, 2019

Use host_alias to define toolpref
Variables host (i.e. host type canonicalized by config.sub) and
host_alias (i.e. the argument to --host) are subtly different, the
right one to use as prefix is $host_alias.

By the way, ac_tool_prefix is defined the same way, maybe it should be
used instead of toolpref?

@glondu glondu force-pushed the glondu:4.08-configure-fixes branch from 96a9b75 to 5b61536 Jul 25, 2019

@glondu

This comment has been minimized.

Copy link
Contributor Author

commented Jul 25, 2019

could you include a Changes entry?

Done in my last push (also rebased on latest 4.08).

Show resolved Hide resolved Changes Outdated

@glondu glondu force-pushed the glondu:4.08-configure-fixes branch from 5b61536 to bcc60bc Jul 25, 2019

Show resolved Hide resolved configure.ac
@gasche

This comment has been minimized.

Copy link
Member

commented Jul 29, 2019

@glondu: there is a check-typo warning on your PR, could you fix it?

./Changes:21.81: [long-line] line is over 80 columns

(that's line 21. You can run ./tools/check-typo <base-branch> to run check-typo at home.)

@glondu glondu force-pushed the glondu:4.08-configure-fixes branch from bcc60bc to bd8411c Jul 30, 2019

@dra27

dra27 approved these changes Jul 30, 2019

Copy link
Contributor

left a comment

All good - is this still definitely for 4.08.1?

@Octachron

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2019

It is, we should have a round of RC for configuration fixes.

@dra27 dra27 merged commit 1e610e2 into ocaml:4.08 Jul 30, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@glondu glondu deleted the glondu:4.08-configure-fixes branch Jul 30, 2019

dra27 added a commit that referenced this pull request Jul 30, 2019

Merge pull request #8830 from glondu/4.08-configure-fixes
Small fixes in configure.ac

(cherry-picked from commit 1e610e2)

dra27 added a commit that referenced this pull request Jul 30, 2019

Merge pull request #8830 from glondu/4.08-configure-fixes
Small fixes in configure.ac

(cherry-picked from commit 1e610e2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.