New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow -with-frame-pointers for clang under linux. #887

Merged
merged 3 commits into from Dec 4, 2016

Conversation

Projects
None yet
2 participants
@bschommer
Contributor

bschommer commented Nov 3, 2016

Allows the usage of frame-pointers if clang is used for x86_64-*-linux.

@gasche gasche added the approved label Nov 3, 2016

@bschommer

This comment has been minimized.

Show comment
Hide comment
@bschommer

bschommer Nov 7, 2016

Contributor

There seems to be some problems. I compiled CompCert with 4.04 (and previous 4.03) with clang 3.9.1 and the resulting binary segfaulted when called. This did not happen when I used the gcc.

Contributor

bschommer commented Nov 7, 2016

There seems to be some problems. I compiled CompCert with 4.04 (and previous 4.03) with clang 3.9.1 and the resulting binary segfaulted when called. This did not happen when I used the gcc.

@bschommer

This comment has been minimized.

Show comment
Hide comment
@bschommer

bschommer Nov 8, 2016

Contributor

Even during the testsuite execution there are linker warnings:

ld: Warning: alignment 16 of symbol `caml_major_ring' in testsuite/../stdlib/libasmrun.a(major_gc.o) is smaller than 64 in src/testsuite/../otherlibs/systhreads/libthreadsnat.a(st_stubs_n.o) => passed

for the torture test
and some other thread tests.

Contributor

bschommer commented Nov 8, 2016

Even during the testsuite execution there are linker warnings:

ld: Warning: alignment 16 of symbol `caml_major_ring' in testsuite/../stdlib/libasmrun.a(major_gc.o) is smaller than 64 in src/testsuite/../otherlibs/systhreads/libthreadsnat.a(st_stubs_n.o) => passed

for the torture test
and some other thread tests.

@bschommer

This comment has been minimized.

Show comment
Hide comment
@bschommer

bschommer Nov 20, 2016

Contributor

I will rebase this PR once #930 is merged since it seems that that is required.

Contributor

bschommer commented Nov 20, 2016

I will rebase this PR once #930 is merged since it seems that that is required.

@bschommer

This comment has been minimized.

Show comment
Hide comment
@bschommer

bschommer Dec 2, 2016

Contributor

Rebased PR, now also the output in Travis should be wiithout linker warnings.

Contributor

bschommer commented Dec 2, 2016

Rebased PR, now also the output in Travis should be wiithout linker warnings.

Show outdated Hide outdated Changes
@@ -94,6 +94,9 @@ Next version (4.05.0):
### Compiler distribution build system:
- GPR#887: allow -with-frame-pointers if clang is used as compiler
(Bernhard Schommer)

This comment has been minimized.

@gasche

gasche Dec 4, 2016

Member

Could you specify "as compiler on Linux"? Otherwise it could confuse MacOS or Windows users.

(Then it's good for merging.)

@gasche

gasche Dec 4, 2016

Member

Could you specify "as compiler on Linux"? Otherwise it could confuse MacOS or Windows users.

(Then it's good for merging.)

This comment has been minimized.

@bschommer

bschommer Dec 4, 2016

Contributor

Done.

@bschommer

bschommer Dec 4, 2016

Contributor

Done.

@gasche gasche merged commit 6022802 into ocaml:trunk Dec 4, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gasche

This comment has been minimized.

Show comment
Hide comment
@gasche

gasche Dec 4, 2016

Member

Thanks! Merged.

Member

gasche commented Dec 4, 2016

Thanks! Merged.

camlspotter pushed a commit to camlspotter/ocaml that referenced this pull request Oct 17, 2017

Allow -with-frame-pointers for clang under linux. (#887)
GPR#897: allow -with-frame-pointers for clang under linux.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment