Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subst: preserve scopes (fixes #8862) #8871

Merged
merged 3 commits into from Aug 16, 2019

Conversation

@trefis
Copy link
Contributor

commented Aug 13, 2019

When adding the explicit scope field to type_expr I remembered to update Ctype.copy but forgot about Subst.typexp, resulting in #8862 .
This PR fixes that

trefis added 3 commits Aug 13, 2019
@trefis trefis requested a review from garrigue Aug 14, 2019
Copy link
Contributor

left a comment

Indeed, we expect scopes to be kept on copy, so this should be true for both kinds of copies.

@trefis trefis merged commit f532be5 into ocaml:trunk Aug 16, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@trefis

This comment has been minimized.

Copy link
Contributor Author

commented Aug 16, 2019

@Octachron this should be safe to backport to 4.09.

@Octachron

This comment has been minimized.

Copy link
Contributor

commented Aug 16, 2019

Agreed.

gasche added a commit that referenced this pull request Sep 10, 2019
subst: preserve scopes (fixes #8862)
(cherry picked from commit f532be5)
gasche added a commit that referenced this pull request Sep 10, 2019
@gasche

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

Cherry-picked in 4.09 ( 64637e3 ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.