Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify the warning of the unboxable-type-in-primitive warning #8914

Merged
merged 1 commit into from Sep 5, 2019

Conversation

@gasche
Copy link
Member

commented Sep 3, 2019

A discussion in a forum thread
https://discuss.ocaml.org/t/primitive-declaration-is-unannotated-and-unboxable/4306
points out that 'unboxable' is ambiguous as it can be read as either
un-boxable or unbox-able.

This commit reformulates the warning to avoid using 'unboxable', but
the very explicit 'may be either boxed or unboxed', along with a more
detailed explanation of the issue that the warning is about.

@gasche gasche force-pushed the gasche:clarify-unboxed-warning branch from aa513da to 4eb91c2 Sep 3, 2019

@gasche gasche force-pushed the gasche:clarify-unboxed-warning branch 3 times, most recently from 2b1ed00 to e849869 Sep 4, 2019

clarify the warning of the unboxable-type-in-primitive warning
A discussion in a forum thread
  https://discuss.ocaml.org/t/primitive-declaration-is-unannotated-and-unboxable/4306
points out that 'unboxable' is ambiguous as it can be read as either
un-boxable or unbox-able.

This commit reformulates the warning to avoid using 'unboxable', but
the very explicit 'may be either boxed or unboxed', along with a more
detailed explanation of the issue that the warning is about.
@Octachron
Copy link
Contributor

left a comment

The new wording should be much more explicit, which is particularly nice for a somewhat infrequent and easy to fix warning.

@gasche gasche merged commit bf240cb into ocaml:trunk Sep 5, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.