New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the way the ocamldoc bytecode executable is called under Windows. #906

Merged
merged 1 commit into from Nov 10, 2016

Conversation

Projects
None yet
2 participants
@shindere
Contributor

shindere commented Nov 10, 2016

This is a follow-up to PR #808. More specifically, it fixes the problem
reported by @alainfrisch at
#808 (comment)

Many thanks to him for having both reported the issue and suggested a fix.

@shindere shindere changed the title from Fix the way ocamldoc is called under Windows. to Fix the way the ocamldoc bytecode executable is called under Windows. Nov 10, 2016

Fix the way the ocamldoc bytecode executable is called under Windows.
This fixes a problem related to the way ocamldoc's bytecode executable
is called under Windows, reported by @alainfrisch at
#808 (comment)

As he explains, ``Even if the PATH is extended with explicit paths to
otherlibs/win32unix and otherlibs/str, ocamlrun will still look up
the stub dlls in the installation directory first, as can be seen by
setting OCAMLRUNPARAM=v=256. If another version was installed in the
same target directory before, the old dlls will be loaded which can lead
to failure (e.g. I just got "Fatal error: unknown C primitive 'unix_lstat'").
A fix could be to set:
CAML_LD_LIBRARY_PATH="../otherlibs/win32unix;../otherlibs/str"
instead of changing PATH''.

This commit implements the proposed fix, due to @alainfrisch.

@alainfrisch alainfrisch merged commit b1e93a2 into ocaml:trunk Nov 10, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@alainfrisch

This comment has been minimized.

Show comment
Hide comment
@alainfrisch

alainfrisch Nov 10, 2016

Contributor

Thanks for the confirmation. Since this is a complement to a recent (unreleased) PR, I guess we can go without a Changelog entry.

Contributor

alainfrisch commented Nov 10, 2016

Thanks for the confirmation. Since this is a complement to a recent (unreleased) PR, I guess we can go without a Changelog entry.

@shindere shindere deleted the shindere:fix-ocamldoc-build-system branch Nov 13, 2016

camlspotter pushed a commit to camlspotter/ocaml that referenced this pull request Oct 17, 2017

Fix the way the ocamldoc bytecode executable is called under Windows. (
…#906)

This fixes a problem related to the way ocamldoc's bytecode executable
is called under Windows, reported by @alainfrisch at
ocaml#808 (comment)

As he explains, ``Even if the PATH is extended with explicit paths to
otherlibs/win32unix and otherlibs/str, ocamlrun will still look up
the stub dlls in the installation directory first, as can be seen by
setting OCAMLRUNPARAM=v=256. If another version was installed in the
same target directory before, the old dlls will be loaded which can lead
to failure (e.g. I just got "Fatal error: unknown C primitive 'unix_lstat'").
A fix could be to set:
CAML_LD_LIBRARY_PATH="../otherlibs/win32unix;../otherlibs/str"
instead of changing PATH''.

This commit implements the proposed fix, due to @alainfrisch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment