Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Code cleanups in asmcomp/s390x #908
I prepared this PR yesterday while working on #903, to try to make the
We may want to throw some or all of it away, based on @xavierleroy's reasonable "if it ain't broke..." principles:
On the other hand, @xavierleroy also pointed out:
In the present PR, there is a bit of consistency stuff on
I'm thinking of removing the
But the gratuitous changes come for free! :-)
What is very easy is to just drop the last commit that inserts some gratuitous newline (I'll update the PR right now). I don't know if you consider the first commit gratuitous as well: it is on its own, but it helps in the refactoring that follows.
I think the whole thing seems ok; even though I agree consistency within each individual emitter is important, it seems good to strive for a situation where the emitters are as consistent between each other as possible also. This helps for changes such as Spacetime, debugging information emission, etc.
I've read this patch carefully this morning and it looks correct to me.