New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "-open" command line flag accept a module path #960

Merged
merged 3 commits into from Dec 9, 2016

Conversation

Projects
None yet
4 participants
@aalekseyev
Contributor

aalekseyev commented Dec 9, 2016

This is a rebased patch from Mantis issue MPR#7137.

Show outdated Hide outdated Changes
@@ -100,6 +100,9 @@ Next version (4.05.0):
- clarify ocamldoc text parsing error messages
(Gabriel Scherer)
- Make "-open" command line flag accept a module path (not a module name)

This comment has been minimized.

@gasche

gasche Dec 9, 2016

Member

Giving the issue numbers is important for traceability. Your entry should start with PR#7137, GPR#960, and given the entry ordering (by MPR first, then by GPR), it should be the first in the section.

@gasche

gasche Dec 9, 2016

Member

Giving the issue numbers is important for traceability. Your entry should start with PR#7137, GPR#960, and given the entry ordering (by MPR first, then by GPR), it should be the first in the section.

This comment has been minimized.

@aalekseyev

aalekseyev Dec 9, 2016

Contributor

I added these issue numbers, improved wording and moved the changelog entry to a section that seems more appropriate.

@aalekseyev

aalekseyev Dec 9, 2016

Contributor

I added these issue numbers, improved wording and moved the changelog entry to a section that seems more appropriate.

aalekseyev added some commits Dec 9, 2016

@gasche

This comment has been minimized.

Show comment
Hide comment
@gasche

gasche Dec 9, 2016

Member

The changelog entry is still at the wrong place ordering-wise in its new section, but oh well. I'll merge now.

Member

gasche commented Dec 9, 2016

The changelog entry is still at the wrong place ordering-wise in its new section, but oh well. I'll merge now.

@gasche gasche merged commit cf19deb into ocaml:trunk Dec 9, 2016

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@aalekseyev aalekseyev deleted the janestreet:dash-open-accepts-module-path branch Dec 9, 2016

@damiendoligez

This comment has been minimized.

Show comment
Hide comment
@damiendoligez

damiendoligez Dec 9, 2016

Member

The test is wrong:

  • "make clean" fails when the directory is already clean
  • "make" doesn't return any test results
Member

damiendoligez commented Dec 9, 2016

The test is wrong:

  • "make clean" fails when the directory is already clean
  • "make" doesn't return any test results
@gasche

This comment has been minimized.

Show comment
Hide comment
@gasche

gasche Dec 9, 2016

Member

Sorry about that, I will rewrite the test.

Member

gasche commented Dec 9, 2016

Sorry about that, I will rewrite the test.

@aalekseyev

This comment has been minimized.

Show comment
Hide comment
@aalekseyev

aalekseyev Dec 9, 2016

Contributor

Sorry about that. Thank you @gasche!

Contributor

aalekseyev commented Dec 9, 2016

Sorry about that. Thank you @gasche!

gasche added a commit that referenced this pull request Dec 9, 2016

@Octachron

This comment has been minimized.

Show comment
Hide comment
@Octachron

Octachron Dec 9, 2016

Contributor

The ocamldoc side has not been updated (see https://github.com/ocaml/ocaml/blob/trunk/ocamldoc/odoc_analyse.ml#L53). Should I fix this point?

Contributor

Octachron commented Dec 9, 2016

The ocamldoc side has not been updated (see https://github.com/ocaml/ocaml/blob/trunk/ocamldoc/odoc_analyse.ml#L53). Should I fix this point?

@aalekseyev

This comment has been minimized.

Show comment
Hide comment
@aalekseyev

aalekseyev Dec 9, 2016

Contributor

Sigh, I should have tried harder to change the type of open_modules.

Yes please.

Contributor

aalekseyev commented Dec 9, 2016

Sigh, I should have tried harder to change the type of open_modules.

Yes please.

Octachron added a commit to Octachron/ocaml that referenced this pull request Dec 20, 2016

Octachron added a commit to Octachron/ocaml that referenced this pull request Dec 21, 2016

Octachron added a commit to Octachron/ocaml that referenced this pull request Dec 21, 2016

gasche added a commit that referenced this pull request Dec 21, 2016

Merge pull request #982 from Octachron/open_path_for_ocamldoc
Extend #960 to include ocamldoc -open

nojb added a commit to nojb/ocaml that referenced this pull request Dec 29, 2016

Make "-open" command line flag accept a module path (#960)
* Make "-open" command line flag accept a module path

nojb added a commit to nojb/ocaml that referenced this pull request Dec 29, 2016

camlspotter pushed a commit to camlspotter/ocaml that referenced this pull request Oct 17, 2017

Make "-open" command line flag accept a module path (#960)
* Make "-open" command line flag accept a module path

camlspotter pushed a commit to camlspotter/ocaml that referenced this pull request Oct 17, 2017

camlspotter pushed a commit to camlspotter/ocaml that referenced this pull request Oct 17, 2017

camlspotter pushed a commit to camlspotter/ocaml that referenced this pull request Oct 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment