Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix fatal error when compiling objects with Flambda #965
One solution might be to use
This was referenced
Jan 10, 2017
Feb 15, 2017
I don't think this issue is fully fixed, as I am getting this error when trying to build core_kernel.v0.9.115.18+07 on the 4.05.0+flambda switch (Linux x64).
This should repro:
The above is not the same bug. It is the issue discussed at #1169. In the end we decided that this was a bug in
...which referred to this issue on GitHub--my knowledge of OCaml compiler internals is scant, so apologies if this is the ultimately the wrong issue.
I don't really agree with that note: the way it is currently written this fatal error is intended to happen when users are using unsafe features. Really this fatal error should be treated the same as the case of mutating an immutable block -- which is currently handled by a warning. I'm going to talk with Mark and Pierre about these cases because personally I don't even think they should warn since the warnings are fragile and can usually be made to appear in safe code using GADTs.
It might be worth adding a note on Mantis about this case, although the issue was already discussed in the GPR I linked to.
It is worth noting that in this case the compiler has a point, it isn't 100% safe to use that version of Base with 4.05 because it is possible for code to segfault due to the new float array optimisation.