New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPR#7443: fix spurious "unused open" warnings in presence of local open in patterns #990

Merged
merged 1 commit into from Dec 29, 2016

Conversation

Projects
None yet
2 participants
@Octachron
Contributor

Octachron commented Dec 28, 2016

This PR removes spurious warnings about unused open in presence of local open in pattern.
These spurious warnings appeared due to Typecore.contain_gadt erroneously (and accidentally) invoking the use tracking mechanism of type_open.

@gasche

This comment has been minimized.

Show comment
Hide comment
@gasche

gasche Dec 28, 2016

Member

No problem! The reason why I use the feature is that I like it :-)

The patch looks highly non-invasive, so I would tempted to propose to merge it without disturbing @alainfrisch between his turkey and his champagne.

(You could mention the GPR number in the Changes entry.)

Member

gasche commented Dec 28, 2016

No problem! The reason why I use the feature is that I like it :-)

The patch looks highly non-invasive, so I would tempted to propose to merge it without disturbing @alainfrisch between his turkey and his champagne.

(You could mention the GPR number in the Changes entry.)

@gasche gasche merged commit 09d743a into ocaml:trunk Dec 29, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gasche

This comment has been minimized.

Show comment
Hide comment
@gasche

gasche Dec 29, 2016

Member

Merged, thanks! I will check that my examples are fixed and close the PR.

Member

gasche commented Dec 29, 2016

Merged, thanks! I will check that my examples are fixed and close the PR.

camlspotter pushed a commit to camlspotter/ocaml that referenced this pull request Oct 17, 2017

Merge pull request #990 from Octachron/open_pattern_unused_module_war…
…ning

MPR#7443: fix spurious "unused open" warnings in presence of local open in patterns
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment