New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ``make install' for the Windows build system #991

Merged
merged 1 commit into from Dec 29, 2016

Conversation

Projects
None yet
3 participants
@shindere
Contributor

shindere commented Dec 29, 2016

On Windows, installing worked only when the native compiler was
previously compiled.

I discovered this while working on merging the main build systems but
would prefer this to be fixed before the merge itself.

@dra27

This comment has been minimized.

Show comment
Hide comment
@dra27

dra27 Dec 29, 2016

Contributor

Looks good - I assume you've tested it? 😄

Worth a Changes entry in "Compiler distribution build system", I think.

Contributor

dra27 commented Dec 29, 2016

Looks good - I assume you've tested it? 😄

Worth a Changes entry in "Compiler distribution build system", I think.

@dra27 dra27 added the approved label Dec 29, 2016

Fix ``make install' for the Windows build system
Before this commit, the installopt target was a prerequisite of the
install target. This means it was run even when the native compilers
were not compiled.

Thus, the sequence

  make -f Makefile.nt world
  make -f Makefile.nt install

failed before this commit.

This commit fixes this by running the installopt target only if ocamlopt
exists, as is done for the Unix build system. It also removes the
installbyt target.
@shindere

This comment has been minimized.

Show comment
Hide comment
@shindere

shindere Dec 29, 2016

Contributor
Contributor

shindere commented Dec 29, 2016

@gasche gasche merged commit 5b496d0 into ocaml:trunk Dec 29, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gasche

This comment has been minimized.

Show comment
Hide comment
@gasche

gasche Dec 29, 2016

Member

Merged, thanks. We wouldn't want to delay the merging work :-)

Member

gasche commented Dec 29, 2016

Merged, thanks. We wouldn't want to delay the merging work :-)

@shindere

This comment has been minimized.

Show comment
Hide comment
@shindere

shindere Dec 29, 2016

Contributor
Contributor

shindere commented Dec 29, 2016

@shindere shindere deleted the shindere:fix-windows-make-install branch Dec 29, 2016

camlspotter pushed a commit to camlspotter/ocaml that referenced this pull request Oct 17, 2017

Merge pull request #991 from shindere/fix-windows-make-install
Fix ``make install' for the Windows build system
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment