Skip to content

[camlp5] New release 7.03, compatible with OCaml 4.06.0. - #10523

Merged
gasche merged 1 commit into
ocaml:masterfrom
ejgallego:camlp5_update
Oct 26, 2017
Merged

[camlp5] New release 7.03, compatible with OCaml 4.06.0.#10523
gasche merged 1 commit into
ocaml:masterfrom
ejgallego:camlp5_update

Conversation

@ejgallego

Copy link
Copy Markdown
Contributor

No description provided.

@camelus

camelus commented Oct 23, 2017

Copy link
Copy Markdown
Contributor
✅ All lint checks passed 506b5e5
  • These packages passed lint tests: camlp5.7.03

✅ Installability check (7610 → 7611)
  • new installable packages (1): camlp5.7.03

@ejgallego ejgallego changed the title [camlp5] New release, compatible with OCaml 4.06.0. [camlp5] New release 7.03, compatible with OCaml 4.06.0. Oct 24, 2017
@ejgallego

Copy link
Copy Markdown
Contributor Author

CI Failure with 4.06 looks due to the use of an old 4.06 image, but can't tell for sure.

@gasche

gasche commented Oct 25, 2017

Copy link
Copy Markdown
Member

@avsm the magic numbers used by the OCaml implementation were bumped after beta2 (not a great idea), and @ejgallego's intuition that the CI is using the older magic number sounds reasonable. Do you know when the images used for 4.06 testing were built? Are they fixed on beta2?

@ejgallego

Copy link
Copy Markdown
Contributor Author

@avsm the magic numbers used by the OCaml implementation were bumped after beta2 (not a great idea),

Indeed @gasche , maybe a reasonable policy is that parsertree/magic interfaces are expected to stable once the first beta appears?

@gasche

gasche commented Oct 25, 2017

Copy link
Copy Markdown
Member

Well we sure made a mistake by not updating the magic numbers before the betas, but not updating them at all would have been even worse so that's how it is. I will do an extra beta or rc this week.

@ejgallego

Copy link
Copy Markdown
Contributor Author

The CI says it is using the 4.06.0+trunk switch, but indeed I couldn't locate a git hash of the exact version used. I think that would be a useful data to have in the logs, where can I submit a feature request? On this repository?

@gasche

gasche commented Oct 26, 2017

Copy link
Copy Markdown
Member

Let's merge the release now to unblock Coq testing. If it turns out @ejgallego did a mistake we can always merge a new release and mark this one incompatible with 4.06.0.

@gasche
gasche merged commit 7f3dae2 into ocaml:master Oct 26, 2017
@ejgallego
ejgallego deleted the camlp5_update branch October 26, 2017 13:32
@ejgallego

Copy link
Copy Markdown
Contributor Author

Thanks @gasche , working fine in my opam setup.

@avsm

avsm commented Oct 27, 2017 via email

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants