New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[camlp5] New release 7.03, compatible with OCaml 4.06.0. #10523

Merged
merged 1 commit into from Oct 26, 2017

Conversation

Projects
None yet
4 participants
@ejgallego
Contributor

ejgallego commented Oct 23, 2017

No description provided.

@camelus

This comment has been minimized.

Contributor

camelus commented Oct 23, 2017

All lint checks passed 506b5e5
  • These packages passed lint tests: camlp5.7.03

Installability check (7610 → 7611)
  • new installable packages (1): camlp5.7.03

@ejgallego ejgallego changed the title from [camlp5] New release, compatible with OCaml 4.06.0. to [camlp5] New release 7.03, compatible with OCaml 4.06.0. Oct 24, 2017

@ejgallego

This comment has been minimized.

Contributor

ejgallego commented Oct 24, 2017

CI Failure with 4.06 looks due to the use of an old 4.06 image, but can't tell for sure.

@gasche

This comment has been minimized.

Member

gasche commented Oct 25, 2017

@avsm the magic numbers used by the OCaml implementation were bumped after beta2 (not a great idea), and @ejgallego's intuition that the CI is using the older magic number sounds reasonable. Do you know when the images used for 4.06 testing were built? Are they fixed on beta2?

@ejgallego

This comment has been minimized.

Contributor

ejgallego commented Oct 25, 2017

@avsm the magic numbers used by the OCaml implementation were bumped after beta2 (not a great idea),

Indeed @gasche , maybe a reasonable policy is that parsertree/magic interfaces are expected to stable once the first beta appears?

@gasche

This comment has been minimized.

Member

gasche commented Oct 25, 2017

Well we sure made a mistake by not updating the magic numbers before the betas, but not updating them at all would have been even worse so that's how it is. I will do an extra beta or rc this week.

@ejgallego

This comment has been minimized.

Contributor

ejgallego commented Oct 25, 2017

The CI says it is using the 4.06.0+trunk switch, but indeed I couldn't locate a git hash of the exact version used. I think that would be a useful data to have in the logs, where can I submit a feature request? On this repository?

@gasche

This comment has been minimized.

Member

gasche commented Oct 26, 2017

Let's merge the release now to unblock Coq testing. If it turns out @ejgallego did a mistake we can always merge a new release and mark this one incompatible with 4.06.0.

@gasche gasche merged commit 7f3dae2 into ocaml:master Oct 26, 2017

8 of 11 checks passed

ci/datakit/3 V1.2 Compilers OCaml 4.06.0 failed
Details
ci/datakit/4 V1.2 Common Distros depfail
Details
ci/datakit/5 V1.2 All Distros depfail
Details
camelus All tests passed
ci/datakit/1 V1.2 Build V1.2 Build
Details
ci/datakit/1 V2.0 Build V2.0 Build
Details
ci/datakit/2 V2.0 Revdeps V2.0 Revdeps
Details
ci/datakit/3 V2.0 Compilers V2.0 Compilers
Details
ci/datakit/4 V2.0 Common Distros V2.0 Common Distros
Details
ci/datakit/5 V2.0 All Distros V2.0 All Distros
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ejgallego ejgallego deleted the ejgallego:camlp5_update branch Oct 26, 2017

@ejgallego

This comment has been minimized.

Contributor

ejgallego commented Oct 26, 2017

Thanks @gasche , working fine in my opam setup.

@avsm

This comment has been minimized.

Member

avsm commented Oct 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment