New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package reason.3.0.3 #10869

Merged
merged 1 commit into from Nov 28, 2017

Conversation

Projects
None yet
2 participants
@jordwalke
Contributor

jordwalke commented Nov 28, 2017

reason.3.0.3

Reason: Syntax & Toolchain for OCaml

Reason provides a new ES6-inspired syntax for OCaml. It's also the umbrella
project for a set of tools for the OCaml & JavaScript ecosystems.



馃惈 Pull-request generated by opam-publish v0.3.5

@jordwalke

This comment has been minimized.

Show comment
Hide comment
@jordwalke

jordwalke Nov 28, 2017

Contributor

Some of the tests were failing because they couldn't download the sources for very common packages such as https://github.com/let-def/ppx_tools_versioned/archive/5.0.1.tar.gz - I wonder if Github just had some kind of an outage. I manually triggered a rebuild (which is cool that I can do that now - interesting how I didn't even have to log in and it let me trigger a rebuild (what's the harm right?))

Contributor

jordwalke commented Nov 28, 2017

Some of the tests were failing because they couldn't download the sources for very common packages such as https://github.com/let-def/ppx_tools_versioned/archive/5.0.1.tar.gz - I wonder if Github just had some kind of an outage. I manually triggered a rebuild (which is cool that I can do that now - interesting how I didn't even have to log in and it let me trigger a rebuild (what's the harm right?))

jordwalke added a commit to facebook/reason that referenced this pull request Nov 28, 2017

More liberal menhir version constraint.
The [opam release](ocaml/opam-repository#10869)
was failing in a way that seemed related to Menhir. Only on linux though
- and it wasn't being caught in our own CI - only OPAM's. Must be for
some configuration we don't test. Making menhir dep more liberal to see
if it will fix our attempted release.

Summary:

Test Plan:

Reviewers:

CC:
@jordwalke

This comment has been minimized.

Show comment
Hide comment
@jordwalke

jordwalke Nov 28, 2017

Contributor

So, not even a restart of those failed builds seems to work. What's up with these strange Compilers V2 errors about:

[ERROR] The sources of the following couldn't be obtained, aborting:
          - lwt.3.1.0

And

[ERROR] The sources of the following couldn't be obtained, aborting:
          - camomile.0.8.7
          - cppo.1.6.0
          - jbuilder.1.0+beta16

etc?

Contributor

jordwalke commented Nov 28, 2017

So, not even a restart of those failed builds seems to work. What's up with these strange Compilers V2 errors about:

[ERROR] The sources of the following couldn't be obtained, aborting:
          - lwt.3.1.0

And

[ERROR] The sources of the following couldn't be obtained, aborting:
          - camomile.0.8.7
          - cppo.1.6.0
          - jbuilder.1.0+beta16

etc?

@avsm

This comment has been minimized.

Show comment
Hide comment
@avsm

avsm Nov 28, 2017

Member

There's a failure in Menhir as well, on some versions:

#=== ERROR while installing reason.3.0.3 ======================================#
# opam-version 1.2.2
# os           linux
# command      jbuilder build -p reason -j 4
# path         /home/travis/.opam/4.03.0/build/reason.3.0.3
# compiler     4.03.0
# exit-code    1
# env-file     /home/travis/.opam/4.03.0/build/reason.3.0.3/reason-13173-76f493.env
# stdout-file  /home/travis/.opam/4.03.0/build/reason.3.0.3/reason-13173-76f493.out
# stderr-file  /home/travis/.opam/4.03.0/build/reason.3.0.3/reason-13173-76f493.err
### stderr ###
# [...]
#     ocamlopt src/reason-parser/menhir_error_processor.{cmx,o}
#       ocamlc src/reason-parser/vendor/cmdliner/cmdliner.{cmi,cmti}
#       ocamlc src/reason-parser/vendor/easy_format/easy_format.{cmo,cmt}
#     ocamlopt src/reason-parser/menhir_error_processor.exe (exit 2)
# (cd _build/default && /home/travis/.opam/4.03.0/bin/ocamlopt.opt -w -40 -g -o src/reason-parser/menhir_error_processor.exe -I /home/travis/.opam/4.03.0/lib/menhirSdk /home/travis/.opam/4.03.0/lib/menhirSdk/menhirSdk.cmx src/reason-parser/menhir_error_processor.cmx)
# File "_none_", line 1:
# Error: No implementations provided for the following modules:
#          Unix referenced from /home/travis/.opam/4.03.0/lib/menhirSdk/menhirSdk.cmx
# 
# Waiting for 1 job to finish.
Member

avsm commented Nov 28, 2017

There's a failure in Menhir as well, on some versions:

#=== ERROR while installing reason.3.0.3 ======================================#
# opam-version 1.2.2
# os           linux
# command      jbuilder build -p reason -j 4
# path         /home/travis/.opam/4.03.0/build/reason.3.0.3
# compiler     4.03.0
# exit-code    1
# env-file     /home/travis/.opam/4.03.0/build/reason.3.0.3/reason-13173-76f493.env
# stdout-file  /home/travis/.opam/4.03.0/build/reason.3.0.3/reason-13173-76f493.out
# stderr-file  /home/travis/.opam/4.03.0/build/reason.3.0.3/reason-13173-76f493.err
### stderr ###
# [...]
#     ocamlopt src/reason-parser/menhir_error_processor.{cmx,o}
#       ocamlc src/reason-parser/vendor/cmdliner/cmdliner.{cmi,cmti}
#       ocamlc src/reason-parser/vendor/easy_format/easy_format.{cmo,cmt}
#     ocamlopt src/reason-parser/menhir_error_processor.exe (exit 2)
# (cd _build/default && /home/travis/.opam/4.03.0/bin/ocamlopt.opt -w -40 -g -o src/reason-parser/menhir_error_processor.exe -I /home/travis/.opam/4.03.0/lib/menhirSdk /home/travis/.opam/4.03.0/lib/menhirSdk/menhirSdk.cmx src/reason-parser/menhir_error_processor.cmx)
# File "_none_", line 1:
# Error: No implementations provided for the following modules:
#          Unix referenced from /home/travis/.opam/4.03.0/lib/menhirSdk/menhirSdk.cmx
# 
# Waiting for 1 job to finish.
@jordwalke

This comment has been minimized.

Show comment
Hide comment
@jordwalke

jordwalke Nov 28, 2017

Contributor

@avsm I suspect the Menhir failure is legitimate (though not sure why it was never encountered before). I'm going to update the Menhir version and see if it works (seems to only fail on Linux). But the other error messages are pretty strange. Sounds like network failure.

Contributor

jordwalke commented Nov 28, 2017

@avsm I suspect the Menhir failure is legitimate (though not sure why it was never encountered before). I'm going to update the Menhir version and see if it works (seems to only fail on Linux). But the other error messages are pretty strange. Sounds like network failure.

jordwalke added a commit to facebook/reason that referenced this pull request Nov 28, 2017

More liberal menhir version constraint.
The [opam release](ocaml/opam-repository#10869)
was failing in a way that seemed related to Menhir. Only on linux though
- and it wasn't being caught in our own CI - only OPAM's. Must be for
some configuration we don't test. Making menhir dep more liberal to see
if it will fix our attempted release.

Summary:

Test Plan:

Reviewers:

CC:
@jordwalke

This comment has been minimized.

Show comment
Hide comment
@jordwalke

jordwalke Nov 28, 2017

Contributor

Another small feedback about opam-publish to anyone who is looking for ways to improve opam-publish

  1. The release directory doesn't seem to be updated when trying a second time: I fixed my 3.0.3 release hosted on github, and reran the opam-publish prepare && opam-publish submit reason.3.0.3 commands, but since I had a left over reason.3.0.3/ directory with the opam/desc/url file, it didn't update it to see my new changes that I made since trying again. That seems like an easy thing to fix, but I'm curious if anyone else ran into it.
  2. opam-publish required that I brew install gmp. That's not ideal, but not sure if there's another way.
Contributor

jordwalke commented Nov 28, 2017

Another small feedback about opam-publish to anyone who is looking for ways to improve opam-publish

  1. The release directory doesn't seem to be updated when trying a second time: I fixed my 3.0.3 release hosted on github, and reran the opam-publish prepare && opam-publish submit reason.3.0.3 commands, but since I had a left over reason.3.0.3/ directory with the opam/desc/url file, it didn't update it to see my new changes that I made since trying again. That seems like an easy thing to fix, but I'm curious if anyone else ran into it.
  2. opam-publish required that I brew install gmp. That's not ideal, but not sure if there's another way.
@jordwalke

This comment has been minimized.

Show comment
Hide comment
@jordwalke

jordwalke Nov 28, 2017

Contributor

Many failures seem to be things like:

# ocaml-migrate-parsetree-1.0.7/.gitignore: Cannot write: No space left on devicetar: ocaml-migrate-parsetree-1.0.7/.ocp-indent: Cannot write: No space left on device
# tar: Exiting with failure status due to previous errors
Contributor

jordwalke commented Nov 28, 2017

Many failures seem to be things like:

# ocaml-migrate-parsetree-1.0.7/.gitignore: Cannot write: No space left on devicetar: ocaml-migrate-parsetree-1.0.7/.ocp-indent: Cannot write: No space left on device
# tar: Exiting with failure status due to previous errors
@jordwalke

This comment has been minimized.

Show comment
Hide comment
@jordwalke

jordwalke Nov 28, 2017

Contributor

@avsm all the current failures are regarding "no space left on device". This is blocking us. What do you recommend?

Contributor

jordwalke commented Nov 28, 2017

@avsm all the current failures are regarding "no space left on device". This is blocking us. What do you recommend?

@avsm

This comment has been minimized.

Show comment
Hide comment
@avsm

avsm Nov 28, 2017

Member

I'm clearing out the machine now; there's a slow space leak somewhere that's filling up one of the volumes that I think I've tracked down.

Member

avsm commented Nov 28, 2017

I'm clearing out the machine now; there's a slow space leak somewhere that's filling up one of the volumes that I think I've tracked down.

@avsm

This comment has been minimized.

Show comment
Hide comment
@avsm

avsm Nov 28, 2017

Member

Another small feedback about opam-publish to anyone who is looking for ways to improve opam-publish

Thanks for the feedback. It'll be lost here in a random PR. Feedback on opam-publish is best accrued on its upstream issue tracker at https://github.com/ocaml/opam-publish. It's going to get more attention as the opam2 release process comes together next month.

Member

avsm commented Nov 28, 2017

Another small feedback about opam-publish to anyone who is looking for ways to improve opam-publish

Thanks for the feedback. It'll be lost here in a random PR. Feedback on opam-publish is best accrued on its upstream issue tracker at https://github.com/ocaml/opam-publish. It's going to get more attention as the opam2 release process comes together next month.

@avsm

This comment has been minimized.

Show comment
Hide comment
@avsm

avsm Nov 28, 2017

Member

[ERROR] The sources of the following couldn't be obtained, aborting:
- lwt.3.1.0

These appear to be GitHub returning bad gateway errors -- a transient problem.

Member

avsm commented Nov 28, 2017

[ERROR] The sources of the following couldn't be obtained, aborting:
- lwt.3.1.0

These appear to be GitHub returning bad gateway errors -- a transient problem.

@avsm avsm merged commit cb7d5f3 into ocaml:master Nov 28, 2017

8 of 10 checks passed

ci/datakit/4 V2.0 Common Distros CentOS7 failed
Details
ci/datakit/5 V2.0 All Distros depfail
Details
ci/datakit/1 V1.2 Build V1.2 Build
Details
ci/datakit/1 V2.0 Build V2.0 Build
Details
ci/datakit/2 V2.0 Revdeps V2.0 Revdeps
Details
ci/datakit/3 V1.2 Compilers V1.2 Compilers
Details
ci/datakit/3 V2.0 Compilers V2.0 Compilers
Details
ci/datakit/4 V1.2 Common Distros V1.2 Common Distros
Details
ci/datakit/5 V1.2 All Distros V1.2 All Distros
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@avsm

This comment has been minimized.

Show comment
Hide comment
@avsm

avsm Nov 28, 2017

Member

Thanks! You may want to announce this on https://discuss.ocaml.org, where we have a Community category and an announce tag for this purpose.

Member

avsm commented Nov 28, 2017

Thanks! You may want to announce this on https://discuss.ocaml.org, where we have a Community category and an announce tag for this purpose.

@jordwalke

This comment has been minimized.

Show comment
Hide comment
@jordwalke

jordwalke Nov 28, 2017

Contributor

@avsm thanks for the tip: Announced here.

Contributor

jordwalke commented Nov 28, 2017

@avsm thanks for the tip: Announced here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment