Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix camlp5 uninstall #11443

Merged
merged 1 commit into from Feb 18, 2018
Merged

fix camlp5 uninstall #11443

merged 1 commit into from Feb 18, 2018

Conversation

@fdopen
Copy link
Contributor

@fdopen fdopen commented Feb 18, 2018

See #11440
I've noticed it, but didn't take it serious. 'rm -rf /' doesn't work with rm of coreutils or any other version of 'rm' I've seen. It will just print a warning. If this is not a universal feature, it's a very serious problem and this PR should be merged very soon.

@camelus
Copy link
Contributor

@camelus camelus commented Feb 18, 2018

All lint checks passed 98b5ae5
  • These packages passed lint tests: camlp5.7.03

Installability check (8323 → 8323)
@mseri
Copy link
Member

@mseri mseri commented Feb 18, 2018

I am not too happy with the fix. It may be useful as a fast workaround to get in, but this should be also fixed in the camlp5 makefile, setting the DESTDIR to some dummy tmp value or aborting the commands if DESTDIR and/or CAMLP5N are not set.

@mseri mseri merged commit f939384 into ocaml:master Feb 18, 2018
9 of 15 checks passed
9 of 15 checks passed
ci/datakit/4 V1.2 Common Distros Alpine 3.6 failed
Details
ci/datakit/5 V1.2 All Distros depfail
Details
ci/datakit/1 arm64 V2.0 Build Waiting for resource in "docker"
Details
ci/datakit/2 arm64 V2.0 Revdeps waiting
Details
ci/datakit/3 arm64 V2.0 Compilers waiting
Details
ci/datakit/4 arm64 V2.0 Common Distros waiting
Details
camelus All tests passed
ci/datakit/1 V1.2 Build V1.2 Build
Details
ci/datakit/1 V2.0 Build V2.0 Build
Details
ci/datakit/2 V2.0 Revdeps V2.0 Revdeps
Details
ci/datakit/3 V1.2 Compilers V1.2 Compilers
Details
ci/datakit/3 V2.0 Compilers V2.0 Compilers
Details
ci/datakit/4 V2.0 Common Distros V2.0 Common Distros
Details
ci/datakit/5 V2.0 All Distros V2.0 All Distros
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@thierry-martinez
Copy link
Contributor

@thierry-martinez thierry-martinez commented Feb 20, 2018

Camlp5 Makefile is now fixed (@roglo): camlp5/camlp5@d561693

@fdopen fdopen deleted the fdopen:camlp5 branch Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants