fix camlp5 uninstall - #11443
Merged
Merged
Conversation
Contributor
✅ All lint checks passed 98b5ae5
✅ Installability check (8323 → 8323) |
Member
|
I am not too happy with the fix. It may be useful as a fast workaround to get in, but this should be also fixed in the |
Contributor
|
Camlp5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #11440
I've noticed it, but didn't take it serious. 'rm -rf /' doesn't work with rm of coreutils or any other version of 'rm' I've seen. It will just print a warning. If this is not a universal feature, it's a very serious problem and this PR should be merged very soon.