Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package herdtools7.7.54 #14509

Merged
merged 8 commits into from Jul 16, 2019
Merged

Package herdtools7.7.54 #14509

merged 8 commits into from Jul 16, 2019

Conversation

maranget
Copy link
Contributor

herdtools7.7.54

The herdtools suite for simulating and studying weak memory models



🐫 Pull-request generated by opam-publish v2.0.0

@camelus
Copy link
Contributor

camelus commented Jul 15, 2019

☀️ All lint checks passed a63c1b6
  • These packages passed lint tests: herdtools7.7.54

☀️ Installability check (+1)
  • new installable packages (1): herdtools7.7.54

bug-reports: "http://github.com/herd/herdtools7/issues/"
doc: "http://diy.inria.fr/doc/index.html"
dev-repo: "git+https://github.com/herd/herdtools7.git"
build: ["./dune-build.sh" "%{prefix}%"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the code and I'm not too sure what all this shell boilerplate is about

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I've tried your package locally and it doesn't work. It just installs empty directories

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried to make it work using dune + a simple configure script to send a PR back to you but I'm not sure to understand what you wanted installed in the first place. What executables do you want to install? Is herd a library or an executable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am working on it. I do not understand what happens either.
To answer your question, the intend is to install several exectables (herd7,litmus7 etc.) in PREFIX/bin, as well as files in PREFIX/share.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure you can do all that with dune without any shell scripts

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be the case that one can do all that with dune, but I do not know how to proceed...

maranget and others added 3 commits July 15, 2019 13:56
@maranget
Copy link
Contributor Author

Hi, the package now has passed all checks. Would you consider merging in ?

--Luc

@kit-ty-kate
Copy link
Member

Ok fine. I tried to have everything using dune but I stumbled upon ocaml/dune#1868 so I give up for now but once this is fixed. As I understand you want a way to also install it locally without opam so this requires the dune issue to be fixed to get rid of every shell scripts. I might have a partial solution in the meantime but for now this is more or less ok.

Thanks.

@kit-ty-kate kit-ty-kate merged commit ad8a150 into ocaml:master Jul 16, 2019
@maranget maranget deleted the opam-publish-herdtools7.7.54 branch July 16, 2019 12:04
@maranget
Copy link
Contributor Author

Hi Kate,

Installing the contents of various repositories /libdir into PREFIX/share/herdtools7/ is not the only difficulty I ran across. I could not find a simple way to instruct dune to install various executables herd.exe, litmus.exe etc. as PREFIX/bin/herd7, PREFIX/bin/litmus7, etc. Hence the shell scripts

@kit-ty-kate
Copy link
Member

Hi Kate,

Installing the contents of various repositories /libdir into PREFIX/share/herdtools7/ is not the only difficulty I ran across. I could not find a simple way to instruct dune to install various executables herd.exe, litmus.exe etc. as PREFIX/bin/herd7, PREFIX/bin/litmus7, etc. Hence the shell scripts

That is easily fixed with (public_name). For instance:

(executable
  (name litmus)
  (public_name litmus7))

@kit-ty-kate
Copy link
Member

Moreover, without (public_name) nothing gets installed nor built automatically by dune.

@maranget
Copy link
Contributor Author

maranget commented Jul 16, 2019 via email

@kit-ty-kate
Copy link
Member

If you use (names) you can use its counterpart (public_names)

@kit-ty-kate
Copy link
Member

It just follows the same order. The whole thing then would be:

(executables
  (names litmus herd)
  (public_names litmus7 herd7))

@maranget
Copy link
Contributor Author

maranget commented Jul 16, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants