New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package herdtools7.7.54 #14509
Package herdtools7.7.54 #14509
Conversation
☀️ All lint checks passed a63c1b6
☀️ Installability check (+1)
|
bug-reports: "http://github.com/herd/herdtools7/issues/" | ||
doc: "http://diy.inria.fr/doc/index.html" | ||
dev-repo: "git+https://github.com/herd/herdtools7.git" | ||
build: ["./dune-build.sh" "%{prefix}%"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked at the code and I'm not too sure what all this shell boilerplate is about
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I've tried your package locally and it doesn't work. It just installs empty directories
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried to make it work using dune + a simple configure script to send a PR back to you but I'm not sure to understand what you wanted installed in the first place. What executables do you want to install? Is herd
a library or an executable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am working on it. I do not understand what happens either.
To answer your question, the intend is to install several exectables (herd7,litmus7 etc.) in PREFIX/bin, as well as files in PREFIX/share.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure you can do all that with dune without any shell scripts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be the case that one can do all that with dune, but I do not know how to proceed...
Co-Authored-By: Kate <kit.ty.kate@disroot.org>
Co-Authored-By: Kate <kit.ty.kate@disroot.org>
Hi, the package now has passed all checks. Would you consider merging in ? --Luc |
Ok fine. I tried to have everything using Thanks. |
Hi Kate, Installing the contents of various repositories /libdir into PREFIX/share/herdtools7/ is not the only difficulty I ran across. I could not find a simple way to instruct dune to install various executables herd.exe, litmus.exe etc. as PREFIX/bin/herd7, PREFIX/bin/litmus7, etc. Hence the shell scripts |
That is easily fixed with
|
Moreover, without |
> Hi Kate,
>
> Installing the contents of various repositories /libdir into PREFIX/share/herdtools7/ is not the only difficulty I ran across. I could not find a simple way to instruct dune to install various executables herd.exe, litmus.exe etc. as PREFIX/bin/herd7, PREFIX/bin/litmus7, etc. Hence the shell scripts
That is easily fixed with `(public_name)`. For instance:
```
(executable
(name litmus)
(public_name litmus7))
```
Thanks, however there are tens for executable to install in directory tools
and I am using (executables ...). I guess I could replace this by
tens of (executable ...) stanzas.
… --
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#14509 (comment)
|
If you use |
It just follows the same order. The whole thing then would be:
|
It just follows the same order. The whole thing then would be:
```
(executables
(names litmus herd)
(public_names litmus7 herd7))
```
Thanks, I'll try this for the next release.
…
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#14509 (comment)
|
herdtools7.7.54
The herdtools suite for simulating and studying weak memory models
🐫 Pull-request generated by opam-publish v2.0.0