Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ctypes 0.20.0 #20191

Merged
merged 1 commit into from
Dec 10, 2021
Merged

Add ctypes 0.20.0 #20191

merged 1 commit into from
Dec 10, 2021

Conversation

yallop
Copy link
Member

@yallop yallop commented Dec 9, 2021

From CHANGES.md:

Thanks to Martin Kletzander (@nertpinx) and Arseniy Alekseyev (@aalekseyev) for contributions to this release.

@kit-ty-kate
Copy link
Member

It looks like the naked pointer fix didn’t bring ocaml-multicore support:

# running test-raw
# ..
# Ran: 2 tests in: 0.00 seconds.
# OK
# running test-pointers
# ....................FF.....
# ==============================================================================
# Error: Pointer tests:21:returned globals (stubs).
# 
# File "/home/opam/.opam/4.12/.opam-switch/build/ctypes.0.20.0/_build/oUnit-Pointer tests-builder#00.log", line 89, characters 1-1:
# Error: Pointer tests:21:returned globals (stubs) (in the log).
# 
# Raised at OUnitAssert.assert_failure in file "src/lib/ounit2/advanced/oUnitAssert.ml", line 45, characters 2-27
# Called from OUnitRunner.run_one_test.(fun) in file "src/lib/ounit2/advanced/oUnitRunner.ml", line 83, characters 13-26
# 
# not equal
# ------------------------------------------------------------------------------
# ==============================================================================
# Error: Pointer tests:20:returned globals (foreign).
# 
# File "/home/opam/.opam/4.12/.opam-switch/build/ctypes.0.20.0/_build/oUnit-Pointer tests-builder#00.log", line 82, characters 1-1:
# Error: Pointer tests:20:returned globals (foreign) (in the log).
# 
# Raised at OUnitAssert.assert_failure in file "src/lib/ounit2/advanced/oUnitAssert.ml", line 45, characters 2-27
# Called from OUnitRunner.run_one_test.(fun) in file "src/lib/ounit2/advanced/oUnitRunner.ml", line 83, characters 13-26
# 
# not equal
# ------------------------------------------------------------------------------
# Ran: 27 tests in: 0.01 seconds.
# FAILED: Cases: 27 Tried: 27 Errors: 0 Failures: 2 Skip:  0 Todo: 0 Timeouts: 0.
# make: *** [Makefile.tests:1395: run-test-pointers] Error 1

Is that expected?

@yallop
Copy link
Member Author

yallop commented Dec 9, 2021

It's not expected; it's an issue with Multicore OCaml (ocaml-multicore/ocaml-multicore#779).

@kit-ty-kate
Copy link
Member

Thanks a lot!

@kit-ty-kate kit-ty-kate merged commit 6dcbce4 into ocaml:master Dec 10, 2021
@yallop yallop deleted the ctypes-0.20.0 branch December 10, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants