Use netstring-pcre package to build ocsigenserver. #872

Merged
merged 1 commit into from Jul 3, 2013

4 participants

@scjung

In ocamlnet-3.6.5, Netstring_pcre module is packaged separately in netstring-pcre.
See https://godirepo.camlcity.org/wwwsvn/tags/ocamlnet-3.6.5/ChangeLog?rev=1858&root=lib-ocamlnet2&view=markup

@samoht
OCaml member

@scjung what is this patch fixing exactly ?

@smondet as an active ocsigen user and packager, do you have an opinion on this patch ?

@smondet

It looks fine by me!
(the dependency of ocsigenserver on pcre-ocaml was already there, so it should force ocamlnet to be compiled with Netstring_pcre module).

@scjung was this reported to the ocsigen project?

@samoht samoht merged commit 720b4f9 into ocaml:master Jul 3, 2013
@samoht
OCaml member

Right, merging then. Thx for the quick comments and for the fix.

@scjung

Ooop.... I'm late. Here in East Asia, it's 3am :D

Sorry, my description is a little bit confusing and wrong. In my system (Mac OS X 10.6.8), when I hit opam install ocsigenserver, it simply fails with Unbound module Netstring_pcre. Before ocamlnet 3.6.5, the netstring META file requires netstring-pcre. But after ocamlnet 3.6.5, netstring META file does not require netstring-pcre even --enable-pcre is used. And because ocsigenserver makefiles specifies only netstring, it fails to build.

@smondet I didn't report it yet.

@scjung scjung deleted the scjung:fix-ocsigenserver branch Jul 3, 2013
@smondet

Just to confirm:

  • before the merge, I update/upgraded everything and ran into the Netstring_pcre error
  • after the merge, opam install ocsigenserver works again :)
@samoht
OCaml member
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment