Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old xapi packages #9206

Merged
merged 8 commits into from May 26, 2017
Merged

Remove old xapi packages #9206

merged 8 commits into from May 26, 2017

Conversation

@mseri
Copy link
Member

@mseri mseri commented May 17, 2017

No package is depending on them and they are unmaintained and probably not compiling.

We are re-constructing a working opam repository in https://github.com/xapi-project/xs-opam
and we will start updating and maintainig the opam files of the stable libraries.
However some of them, like xapi, xapi-networkd, xapi-idl, ... are always in motion and
we have very strict interdependence: this makes it very hard to guarantee that the packages
constraints are sound enough to be in the official opam repository and their presence in the opam repository makes it hard to manage a switch containing both opam-repository and xs-opam without pinning.

Removing these libraries is the first step towards being able to maintain and update the ones
that are remaining in opam.

Signed-off-by: Marcello Seri marcello.seri@gmail.com

@camelus
Copy link
Contributor

@camelus camelus commented May 17, 2017

All lint checks passed 8607a70
  • These packages passed lint tests: nbd.1.0.3, nbd.2.1.3

Installability check (6678 → 6665)
  • new installable packages (2): nbd.1.0.3 nbd.2.1.3
  • removed broken packages (6): xapi.1.9.56 xapi-idl.0.9.19
    xapi-rrd-transport.0.7.2 xapi-rrdd.0.9.8 xapi-rrdd-plugin.0.6.0
    xapi-xenopsd.0.9.44.1
  • removed installable packages (15): vhd-tool.0.7.8 xapi-backtrace.0.2
    xapi-forkexecd.0.9.2 xapi-idl.0.11.0 xapi-inventory.0.9.1
    xapi-libs-transitional.0.9.6 xapi-netdev.0.9.1 xapi-networkd.0.9.4
    xapi-squeezed.0.10.7 xapi-stdext.0.11.0 xapi-stdext.0.12.0
    xapi-stdext.0.13.0 xapi-tapctl.0.9.2 xapi-xenops.0.9.6
    xapi-xenops-cli.0.9.1
@avsm
Copy link
Member

@avsm avsm commented May 17, 2017

I just want to check on the vhd-tool removal as its on djs55's repository; cc @djs55 -- I seem to remember fixing its upper bounds so its fine to compile now.

xapi-stdext.0.13.0 also needs to be removed i think as it is now uninstallable.

@mseri
Copy link
Member Author

@mseri mseri commented May 17, 2017

Sure. You are correct, I forgot stdext.

I can revert the removal of vhd-tool if needed (but in that case I will have to revert the removal of xapi-tapctl, xapi-backtrace and xapi-stdext).

We might add them back later but with strict constraints on the released versions so that we can guarantee that they compile.

Also there will be soon a PR from @gaborigloi updating the rest of the libraries (new releases and dependencies bounds)

@avsm
Copy link
Member

@avsm avsm commented May 19, 2017

We might add them back later but with strict constraints on the released versions so that we can guarantee that they compile.

I have fixed vhd-tool quite a few times to make sure it compiles -- are you sure it is failing?

e.g. 55c1330 b2856c3 dbb3d10 2440899 4ad8b2e b8d672a 7b3d24a etc etc :-)

@mseri
Copy link
Member Author

@mseri mseri commented May 19, 2017

The reason vhd-tool ended up in the list is that it depends on some of the xapi libs that we wanted to remove and re-introduce with their new versions and updates in a coherent way.

It is just three, rarely changing, libraries, so I am happy to revert the change for them.

@djs55
Copy link
Contributor

@djs55 djs55 commented May 19, 2017

Thanks -- I'd prefer to preserve vhd-tool if possible. Which dependencies of vhd-tool are problematic btw? I'm happy to help try to untangle things if that's useful.

Removing all the xapi- prefixed packages is of course fine -- I'm looking forward to the new versions :)

mseri and others added 4 commits May 16, 2017
No package is depending on them and they are unmaintained and probably not compiling.
We are re-constructing a working opam repository in https://github.com/xapi-project/xs-opam
and we will start updating and maintainig the opam files of the stable libraries.
However some of them, like xapi, xapi-networkd, xapi-idl, ... are always in motion and
we have very strict interdepenencies: this makes it very hard to guarantee that the packages
constraints are sound to be in the opam repository and their presence in the opam repository
makes it impossible to manage a switch containing both opam and xs-opam without pinning.

Removing these libraries is the first step towards being able to maintain and update the ones
that are remining in opam.

Signed-off-by: Marcello Seri <marcello.seri@gmail.com>
Signed-off-by: Marcello Seri <marcello.seri@citrix.com>
Marcello Seri
Signed-off-by: Marcello Seri <marcello.seri@citrix.com>
@mseri mseri force-pushed the mseri:cleanup-stale-packages branch from de151c0 to e682e7c May 19, 2017
@mseri
Copy link
Member Author

@mseri mseri commented May 19, 2017

I am sorry I was likely wrong. I did use opam list --rec --short --depends-on to check the dependencies and I saw there the xapi- dependencies.

@djs55 it turns out that only vhd-tool 0.7.8 is depending on xapi-tapctl (an in turn with plenty of other xapi- libraries, including idl that is one of the ones we were planning to remove and reintroduce with strict version constraints). If it's fine with you, I would remove only that version (and only temporarily).

I have also added an update to nbd to fix a memory leak in the dispatcher.

Marcello Seri
This depends on `xapi-tapctl` and in turns on `xapi-backtrace`, `xapi-forkexecd`, `xapi-idl` and possibly more.

It will be reintroduced when the rest of xapi libraries is re-introduced
with appropriate version constraints.

Signed-off-by: Marcello Seri <marcello.seri@citrix.com>
@avsm
Copy link
Member

@avsm avsm commented May 19, 2017

That sounds good to me -- I appreciate you taking the time to help untangle it all @mseri :)

Marcello Seri
and update lwt constraints.

Signed-off-by: Marcello Seri <marcello.seri@citrix.com>
@mseri mseri force-pushed the mseri:cleanup-stale-packages branch from 76364d6 to bac4e37 May 19, 2017
Marcello Seri
Signed-off-by: Marcello Seri <marcello.seri@citrix.com>
@avsm
Copy link
Member

@avsm avsm commented May 23, 2017

Please let me know when this is ok to merge @mseri, with a lgtm from @jonludlam @djs55 if possible, thanks!

@mseri
Copy link
Member Author

@mseri mseri commented May 23, 2017

Sure, I am trying to figure out why it is failing in two of the configurations

@jonludlam
Copy link
Contributor

@jonludlam jonludlam commented May 24, 2017

lgtm, so long as the updated PR with the new packages comes along soon :-)

Internally we're now building directly from an opam repository (https://github.com/xapi-project/xs-opam) so we'll be able to keep things up-to-date in the main opam-repository much more easily. The one thing we'll have to be careful about is the versions of the dependencies as our xs-opam contains only one version of everything.

@mseri
Copy link
Member Author

@mseri mseri commented May 24, 2017

@avsm I only see a failure on OpenSuse that is unrelated to this PR (https://ci.ocaml.io/ocaml/opam-repository/pr/9206). It's good to merge for me.

@gaborigloi read the comments ⬆️ we should start preparing the PR to reintroduce xapi's stuff and update the updateable :)

"sexplib"
"mirage-block-unix" {< "2.5.0"}
"io-page"
"mirage" {>= "1.1.0" & < "3.0.0"}

This comment has been minimized.

@avsm

avsm May 25, 2017
Member

I think this needs to be mirage-types and not mirage, otherwise this error is happening:

#=== ERROR while installing nbd.2.1.3 =========================================#
# opam-version 1.2.2
# os           linux
# command      make
# path         /home/travis/.opam/4.04.0/build/nbd.2.1.3
# compiler     4.04.0
# exit-code    2
# env-file     /home/travis/.opam/4.04.0/build/nbd.2.1.3/nbd-25813-20b76c.env
# stdout-file  /home/travis/.opam/4.04.0/build/nbd.2.1.3/nbd-25813-20b76c.out
# stderr-file  /home/travis/.opam/4.04.0/build/nbd.2.1.3/nbd-25813-20b76c.err
### stdout ###
# [...]
# /home/travis/.opam/4.04.0/bin/ocamlfind ocamldep -package cstruct -package cstruct.ppx -package io-page -package lwt -package mirage-types.lwt -package ppx_sexp_conv -package sexplib -modules lib/mirror.ml > lib/mirror.ml.depends
# /home/travis/.opam/4.04.0/bin/ocamlfind ocamlc -c -g -annot -bin-annot -package cstruct -package cstruct.ppx -package io-page -package lwt -package mirage-types.lwt -package ppx_sexp_conv -package sexplib -I lib -o lib/protocol.cmo lib/protocol.ml
# /home/travis/.opam/4.04.0/bin/ocamlfind ocamlc -c -g -annot -bin-annot -package cstruct -package cstruct.ppx -package io-page -package lwt -package mirage-types.lwt -package ppx_sexp_conv -package sexplib -I lib -o lib/client.cmo lib/client.ml
# + /home/travis/.opam/4.04.0/bin/ocamlfind ocamlc -c -g -annot -bin-annot -package cstruct -package cstruct.ppx -package io-page -package lwt -package mirage-types.lwt -package ppx_sexp_conv -package sexplib -I lib -o lib/client.cmo lib/client.ml
# File "lib/client.ml", line 1:
# Error: The implementation lib/client.ml
#        does not match the interface lib/client.cmi:
#        The value `connect' is required but not provided
#        The value `id' is required but not provided
# Command exited with code 2.
### stderr ###
# W: Cannot find source file matching module 'nbd' in library nbd.
# W: Use InterfacePatterns or ImplementationPatterns to define this file with feature "source_patterns".
# E: Failure("Command ''/home/travis/.opam/4.04.0/bin/ocamlbuild' lib/nbd.cma lib/nbd.cmxa lib/nbd.a lib/nbd.cmxs lwt/nbd-lwt.cma lwt/nbd-lwt.cmxa lwt/nbd-lwt.a lwt/nbd-lwt.cmxs cli/main.native -tag debug' terminated with error code 10")
# make: *** [build] Error 1
Marcello Seri
Signed-off-by: Marcello Seri <marcello.seri@citrix.com>
@mseri mseri force-pushed the mseri:cleanup-stale-packages branch from 4aae563 to 8607a70 May 25, 2017
@mseri
Copy link
Member Author

@mseri mseri commented May 26, 2017

I have updated the opam file, thanks.

The two failures I see are:

[ERROR] The sources of the following couldn't be obtained, aborting:
          - ipaddr.2.7.2
        (This may be fixed by running 'opam update')

for the Xcode Travis CI build

and

The following NEW package is going to be installed:
  pinentry

The following 19 packages are going to be upgraded:
  bash gpg2 hwinfo libblkid1 libfdisk1 libmount1 libprocps3 libreadline6 libsmartcols1 libtirpc-netconfig libtirpc3 libuuid1 libwicked-0-6 procps rpcbind util-linux util-linux-systemd wicked wicked-service

19 packages to upgrade, 1 new.
Overall download size: 5.7 MiB. Already cached: 0 B. After the operation, additional 128.1 KiB will be used.
Continue? [y/n/...? shows all options] (y): Cannot read input: bad stream or EOF.
If you run zypper without a terminal, use '--non-interactive' global
option to make zypper use default answers to prompts.
OS package update failed
Removing intermediate container c4a4adcb940a

for OpenSuse ci/datakit/5 v2.0 All Distros.

Can we re-run those?

@avsm
avsm approved these changes May 26, 2017
@avsm
Copy link
Member

@avsm avsm commented May 26, 2017

I think this is fine -- opensuse is sadly unreliable atm due to issues with the repository going interactive. Thanks for all the efforts and cleanup, and look forward to seeing new xapi packages appear soon :-)

@avsm avsm merged commit 9b77d04 into ocaml:master May 26, 2017
9 of 11 checks passed
9 of 11 checks passed
ci/datakit/5 V2.0 All Distros OpenSUSE 42.2 failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
camelus All tests passed
ci/datakit/1 V1.2 Build V1.2 Build
Details
ci/datakit/1 V2.0 Build V2.0 Build
Details
ci/datakit/2 V2.0 Revdeps V2.0 Revdeps
Details
ci/datakit/3 V1.2 Compilers V1.2 Compilers
Details
ci/datakit/3 V2.0 Compilers V2.0 Compilers
Details
ci/datakit/4 V1.2 Common Distros V1.2 Common Distros
Details
ci/datakit/4 V2.0 Common Distros V2.0 Common Distros
Details
ci/datakit/5 V1.2 All Distros V1.2 All Distros
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.