Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for existence of rsync at build/install #1499

Closed
dsheets opened this issue Jul 5, 2014 · 5 comments · Fixed by #1501
Closed

Check for existence of rsync at build/install #1499

dsheets opened this issue Jul 5, 2014 · 5 comments · Fixed by #1501
Milestone

Comments

@dsheets
Copy link
Member

dsheets commented Jul 5, 2014

opam appears to depend on rsync and should fail/complain during install/build if rsync is not present.

@dsheets dsheets added the Bug label Jul 5, 2014
@dsheets
Copy link
Member Author

dsheets commented Jul 5, 2014

Joris (FreeBSD ports maintainer) points out that rsync isn't a hard dep and only required for remotes of kind 'rsync'. I believe it is also required for kind 'local'. Maybe this should be noted somewhere in the install? Or perhaps it should be checked when trying to create a 'local' remote rather than failing with

Fatal error:
"rsync": command not found.

@dbuenzli
Copy link
Contributor

dbuenzli commented Jul 6, 2014

It is used for path-pins aswell I think.

@dsheets
Copy link
Member Author

dsheets commented Jul 6, 2014

For most distros, the existence of rsync is not a problem. The response I got from the FreeBSD port maintainer indicated that, because opam is usable without rsync, rsync was not a dependency of opam. While I agree this is technically correct, it seems that many opam features rely on rsync. Because of this, I think some component, metadata, or documentation should clarify the relationship between opam and rsync.

@AltGr
Copy link
Member

AltGr commented Jul 7, 2014

Would be easy enough to add an
ERROR: 'rsync' command not found, this kind of remotes won't be available

The same should be done for git, darcs, hg ; for curl/wget I don't think you can do much without either.

@AltGr AltGr added this to the 1.2 milestone Jul 7, 2014
@samoht
Copy link
Member

samoht commented Jul 7, 2014

An option should be to add a warning at configuration time as well (although it doesn't prevent the user to install rsync, git, curl later on).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants