Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"make cold" should check that "patch" is installed upfront #3842

Closed
jfehrle opened this issue May 19, 2019 · 2 comments · Fixed by #4006
Closed

"make cold" should check that "patch" is installed upfront #3842

jfehrle opened this issue May 19, 2019 · 2 comments · Fixed by #4006
Milestone

Comments

@jfehrle
Copy link

@jfehrle jfehrle commented May 19, 2019

I'm on cygwin32. make cold failed because I didn't have patch installed. Would be helpful to check on that at the beginning of the build, though probably the total build time between the 2 runs is about the same.

$ make cold
<several thousand lines of output>

rm -rf result
rm -rf cudf
/bin/sh: line 3: patch: command not found
make[2]: *** [Makefile:171: extlib.stamp] Error 127
make[2]: *** Waiting for unfinished jobs....
/bin/sh: line 3: patch: command not found
make[2]: *** [Makefile:173: seq.stamp] Error 127
rm -rf ocamlgraph
rm -rf dose3
/bin/sh: line 3: patch: command not found
make[2]: *** [Makefile:172: ocamlgraph.stamp] Error 127
rm -rf mccs
/bin/sh: line 3: patch: command not found
make[2]: *** [Makefile:171: dose3.stamp] Error 127
rm -rf dune-local
rm dune-local.download
make[2]: Leaving directory '/cygdrive/d/opam-2.0.4/src_ext'
make[1]: *** [Makefile:57: lib-ext] Error 2
make[1]: Leaving directory '/cygdrive/d/opam-2.0.4'
make: *** [Makefile:194: cold] Error 2
@jfehrle

This comment has been minimized.

Copy link
Author

@jfehrle jfehrle commented May 20, 2019

Actually, I think the make repeats building a bunch of .c files, which is slower.

@rjbou

This comment has been minimized.

Copy link
Collaborator

@rjbou rjbou commented Oct 8, 2019

a ./configure is launched during make cold, which check that patch is installed (cf. #3531), but it doesn't interrupt make cold process.
Thanks for the report!

@AltGr AltGr closed this in #4006 Oct 22, 2019
@rjbou rjbou added this to the 2.0.6 milestone Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.