Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Big cleanup in OpamTypes #1206

Merged
merged 2 commits into from Mar 3, 2014

Conversation

Projects
None yet
2 participants
Member

AltGr commented Feb 28, 2014

the everywhere-opened module used to contain lots of various stuff. Now:

  • it contains only types, so no duplication in a .mli is needed
  • utility functions have been moved to OpamTypesBase
  • Action resolution modules and functors have been moved to their own
    modules, with a much cleaner interface. The two instances (with OPAM and CUDF
    modules)
    are also a bit easier to distinguish and understand (OpamSolver converts
    between
    the two)
Member

dsheets commented Mar 1, 2014

If opamTypes.ml contains only types, could it be opamTypes.mli without an ml? This should work and would enforce the lack of values in the module.

Member

AltGr commented Mar 3, 2014

@dsheets true enough, good point.

Member

AltGr commented Mar 3, 2014

(actually this should also solve the issue on travis, since the current Makefile only scans .mlis for installation of the .cmis !)

AltGr added some commits Feb 28, 2014

Big cleanup in OpamTypes
the everywhere-opened module used to contain lots of various stuff. Now:
* it contains only types, so no duplication between .ml / .mli is needed
* utility functions have been moved to OpamTypesBase
* Action resolution modules and functors have been moved to their own
  modules, with a much cleaner interface. The two instances (with OPAM and CUDF modules)
  are also a bit easier to distinguish and understand (OpamSolver converts between
  the two)

AltGr added a commit that referenced this pull request Mar 3, 2014

@AltGr AltGr merged commit 5fd2c8c into ocaml:master Mar 3, 2014

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment