Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Big cleanup in OpamTypes #1206

Merged
merged 2 commits into from

2 participants

@AltGr
Owner

the everywhere-opened module used to contain lots of various stuff. Now:

  • it contains only types, so no duplication in a .mli is needed
  • utility functions have been moved to OpamTypesBase
  • Action resolution modules and functors have been moved to their own modules, with a much cleaner interface. The two instances (with OPAM and CUDF modules) are also a bit easier to distinguish and understand (OpamSolver converts between the two)
@dsheets
Owner

If opamTypes.ml contains only types, could it be opamTypes.mli without an ml? This should work and would enforce the lack of values in the module.

@AltGr
Owner

@dsheets true enough, good point.

@AltGr
Owner

(actually this should also solve the issue on travis, since the current Makefile only scans .mlis for installation of the .cmis !)

AltGr added some commits
@AltGr AltGr Big cleanup in OpamTypes
the everywhere-opened module used to contain lots of various stuff. Now:
* it contains only types, so no duplication between .ml / .mli is needed
* utility functions have been moved to OpamTypesBase
* Action resolution modules and functors have been moved to their own
  modules, with a much cleaner interface. The two instances (with OPAM and CUDF modules)
  are also a bit easier to distinguish and understand (OpamSolver converts between
  the two)
052e48b
@AltGr AltGr opam-rt doesn't like latest cohttp, temporary workaround for travis 892d867
@AltGr AltGr merged commit 5fd2c8c into ocaml:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 3, 2014
  1. @AltGr

    Big cleanup in OpamTypes

    AltGr authored
    the everywhere-opened module used to contain lots of various stuff. Now:
    * it contains only types, so no duplication between .ml / .mli is needed
    * utility functions have been moved to OpamTypesBase
    * Action resolution modules and functors have been moved to their own
      modules, with a much cleaner interface. The two instances (with OPAM and CUDF modules)
      are also a bit easier to distinguish and understand (OpamSolver converts between
      the two)
  2. @AltGr
Something went wrong with that request. Please try again.