Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
fish unconditionally display manpath when fish version is 2.7 or later #3728
Hello, I would like feedback on this change and advice on how to write a test for it. I briefly looked through the test directory and saw some scaffolding for "fake packages", but could not figure out what the right way to set up a "fake switch" is for testing purposes.
My system opam packaged by Manjaro (version
As a workaround, I have been using the following
I removed a conditional and changed it so that
I tested it by
No tests failed as a result of this change. At least one test probably should have failed, though.
Thanks in advance,
Thanks for the proposal!
This special case for
On your proposal, changes will bring back to errored MANPATH setting (cf. 74f8bbd). Is there another way in fish to set
opam have an included test suite that tests only main operation (install, pin, update, upgrade, etc.). Shell features are not tested automatically, only via manual testing.
I changed it to use an
I’m not a
I looked at the fish changelog here: https://fishshell.com/release_notes.html and decided to test for the presence of the
The command in structured in such a way that fish versions prior to 2.3 will attempt to execute a nonexistent
Unfortunately, I can't redirect the stderr output of failing to execute a nonexistent command to
This means that old fishes (prior to 2.3) will get stray output on stderr, but it shouldn't affect the functionality. I don't know a good way to fix it besides redirecting stderr to
Thanks for the changes!
~> builtin -n | grep argparse > /dev/null 2>&1 ~> echo $status 1 ~> builtin -n | grep string > /dev/null 2>&1 ~> echo $status 0
Having error messages (from shell) is an unwanted behaviour, even if it is sometimes just cosmetic, but in this case, when shell hook is enabled