Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small misspellings #3731

Merged
merged 1 commit into from Jan 28, 2019

Conversation

Projects
None yet
3 participants
@MisterDA
Copy link
Contributor

commented Jan 26, 2019

Fix small misspellings.
They were found by https://github.com/client9/misspell.

@dra27
Copy link
Contributor

left a comment

Nice! Reviewing these things always causes one to nit-pick about other things on the same lines...!

CHANGES Outdated
@@ -653,7 +653,7 @@ are not marked).
* improve opam-mk-repo
* fix `opam search` to be caseless
* ability to filter some commands (depending on some predicates) in opam file
* improvments when packages disapear upstream
* improvements when packages disapear upstream

This comment has been minimized.

Copy link
@dra27

dra27 Jan 27, 2019

Contributor

Surprising that this hasn't also caught s/disapear/disappear?

@@ -67,7 +67,7 @@ cases outlined above:
or an explanation for the failure, while perform executes the actions (typically
after user confirmation)

The proposed module interface is purposedly incomplete, as it makes no assumption
The proposed module interface is purposely incomplete, as it makes no assumption

This comment has been minimized.

Copy link
@dra27

dra27 Jan 27, 2019

Contributor
Suggested change
The proposed module interface is purposely incomplete, as it makes no assumption
The proposed module interface is intentionally incomplete, as it makes no assumption

(either a US/UK thing, or just me...)

@@ -71,7 +71,7 @@ When you request to install a (set of) package(s), in general you do not expect
### Specifying preferences for opam

`opam` allows to specify your criteria on the command line, using the `--criteria` option, that will apply only to the current command.
For example if you are a very conservative user, you might try issueing the following command:
For example if you are a very conservative user, you might try issuing the following command:

This comment has been minimized.

Copy link
@dra27

dra27 Jan 27, 2019

Contributor
Suggested change
For example if you are a very conservative user, you might try issuing the following command:
For example, if you are a very conservative user, you might try issuing the following command:
@@ -35,7 +35,7 @@ When you request to install a (set of) package(s), in general you do not expect
### Specifying preferences for opam

Recent versions of `opam` allow to specify your criteria on the command line, using the `--criteria` option, that will apply only to the current command.
For example if you are a very conservative user, you might try issueing the following command:
For example if you are a very conservative user, you might try issuing the following command:

This comment has been minimized.

Copy link
@dra27

dra27 Jan 27, 2019

Contributor
Suggested change
For example if you are a very conservative user, you might try issuing the following command:
For example, if you are a very conservative user, you might try issuing the following command:
@@ -9,7 +9,7 @@

./init-repo.sh -i

* load a inital scenario (this command can be invoked multiple times):
* load a initial scenario (this command can be invoked multiple times):

This comment has been minimized.

Copy link
@dra27

dra27 Jan 27, 2019

Contributor
Suggested change
* load a initial scenario (this command can be invoked multiple times):
* load an initial scenario (this command can be invoked multiple times):
@MisterDA

This comment has been minimized.

Copy link
Contributor Author

commented Jan 27, 2019

Hop! I added your suggestions.

@rjbou

This comment has been minimized.

Copy link
Collaborator

commented Jan 28, 2019

Thanks!

@rjbou rjbou merged commit bc4cc58 into ocaml:master Jan 28, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MisterDA MisterDA deleted the MisterDA:misspellings branch Jan 28, 2019

rjbou added a commit to rjbou/opam that referenced this pull request Feb 1, 2019

rjbou added a commit to rjbou/opam that referenced this pull request Feb 20, 2019

rjbou added a commit to rjbou/opam that referenced this pull request Mar 27, 2019

rjbou added a commit to rjbou/opam that referenced this pull request Mar 27, 2019

@rjbou rjbou referenced this pull request Mar 27, 2019

Merged

2.0.4 backported commits #3805

@rjbou rjbou added this to the 2.0.4 milestone Mar 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.