Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hg opam1.2 url parsing #3754

Merged
merged 1 commit into from Feb 13, 2019

Conversation

Projects
None yet
1 participant
@rjbou
Copy link
Collaborator

commented Feb 13, 2019

hg://https://... is wrongly translated to hg+ssh://https//... instead of hg+https://...

Revert "Correct unnecessary alternation in URL parser"
This reverts commit 7db852f.
This is need to parse old hg & darcs url format

@rjbou rjbou changed the title Fix hg / darcs opam1.2 format parsing Fix hg / darcs opam1.2 url parsing Feb 13, 2019

@rjbou rjbou merged commit b4f1574 into ocaml:master Feb 13, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rjbou rjbou changed the title Fix hg / darcs opam1.2 url parsing Fix hg opam1.2 url parsing Feb 13, 2019

rjbou added a commit to rjbou/opam that referenced this pull request Feb 20, 2019

Revert "Correct unnecessary alternation in URL parser" (ocaml#3754)
This reverts commit 7db852f.
This is needed to parse old hg url format: `hg://https://...` is wrongly translated to `hg+ssh://https//...` instead of `hg+https://...`

@rjbou rjbou added this to the 2.1.0 milestone Feb 28, 2019

rjbou added a commit to rjbou/opam that referenced this pull request Mar 27, 2019

Revert "Correct unnecessary alternation in URL parser" (ocaml#3754)
This reverts commit 7db852f.
This is needed to parse old hg url format: `hg://https://...` is wrongly translated to `hg+ssh://https//...` instead of `hg+https://...`

rjbou added a commit to rjbou/opam that referenced this pull request Mar 27, 2019

Revert "Correct unnecessary alternation in URL parser" (ocaml#3754)
This reverts commit 7db852f.
This is needed to parse old hg url format: `hg://https://...` is wrongly translated to `hg+ssh://https//...` instead of `hg+https://...`

rjbou added a commit to rjbou/opam that referenced this pull request Mar 27, 2019

Revert "Correct unnecessary alternation in URL parser" (ocaml#3754)
This reverts commit 7db852f.
This is needed to parse old hg url format: `hg://https://...` is wrongly translated to `hg+ssh://https//...` instead of `hg+https://...`

@rjbou rjbou referenced this pull request Mar 27, 2019

Merged

2.0.4 backported commits #3805

@rjbou rjbou modified the milestones: 2.1.0, 2.0.4 Mar 28, 2019

rjbou added a commit to rjbou/opam that referenced this pull request Mar 28, 2019

Revert "Correct unnecessary alternation in URL parser" (ocaml#3754)
This reverts commit 7db852f.
This is needed to parse old hg url format: `hg://https://...` is wrongly translated to `hg+ssh://https//...` instead of `hg+https://...`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.