Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pinnings not installing/upgrading already pinned packages #3800

Merged
merged 3 commits into from Mar 28, 2019

Conversation

Projects
None yet
2 participants
@AltGr
Copy link
Member

commented Mar 25, 2019

No description provided.

@AltGr

This comment has been minimized.

Copy link
Member Author

commented Mar 26, 2019

Travis failure unrelated with the patch
(we do opam install lwt as a basic test, and lwt now depends on seq, which is apparently broken on 4.02.3 — @kit-ty-kate ?)

@AltGr

This comment has been minimized.

Copy link
Member Author

commented Mar 26, 2019

@rjbou, is 2.0.3 affected bu this regression ? If so, this would probably deserve a 2.0.4 ?

@rjbou

This comment has been minimized.

Copy link
Collaborator

commented Mar 26, 2019

On travis failure, it's from the image, it have an ocaml 4.02.3 installed, but not with ocamlbuild, and seq depends on ocamlbuild.0 that depend on base-ocamlbuid.

this would probably deserve a 2.0.4 ?

it's contained in 2.0.2, so i'd say yes. We can do a 2.0.4 fixes release.

@rjbou

This comment has been minimized.

Copy link
Collaborator

commented Mar 26, 2019

@AltGr fixed, just need to rebase

@AltGr AltGr force-pushed the OCamlPro:fix-pinupgr branch from 1ba516e to 0c39137 Mar 26, 2019

@AltGr AltGr force-pushed the OCamlPro:fix-pinupgr branch from 0c39137 to 0f1ee06 Mar 27, 2019

@AltGr

This comment has been minimized.

Copy link
Member Author

commented Mar 28, 2019

Rebased (twice), CI build still blocked with the ocamlbuild/seq issue on 4.02.3... :/
@rjbou an idea ?

@rjbou

This comment has been minimized.

Copy link
Collaborator

commented Mar 28, 2019

I suppose that the cache contains an ocaml version without ocamlbuild. I deleted it and relaunched, let's see

@rjbou

This comment has been minimized.

Copy link
Collaborator

commented Mar 28, 2019

I was the cache, 4.02.3 build succeed.

@AltGr

This comment has been minimized.

Copy link
Member Author

commented Mar 28, 2019

Thanks!

@AltGr AltGr merged commit 0194441 into ocaml:master Mar 28, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rjbou

This comment has been minimized.

Copy link
Collaborator

commented Mar 28, 2019

related to #3727

@rjbou rjbou referenced this pull request Mar 28, 2019

Merged

2.0.4 backported commits #3805

@rjbou rjbou added this to the 2.0.4 milestone Mar 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.