Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include .gitattributes in index.tar.gz #3873

Merged
merged 1 commit into from Jun 26, 2019
Merged

Conversation

@dra27
Copy link
Contributor

dra27 commented Jun 15, 2019

ocaml/opam-repository#14287 introduced .gitattributes files to opam-repository. There's no need for the project-specific ones to be included in index.tar.gz so this PR updates OpamHTTP.make_index_tar_gz to exclude them.

At the moment, the files have been removed (ocaml/opam-repository#14294), but I've tested this locally.

Posix has very little to say about tar, so it's possible that the --exclude option locks to this GNU tar. Not sure if that particularly matters for opam admin. It'd be handy if this patch were applied to the opam which regenerates https://opam.ocaml.org/index.tar.gz, though.

@AltGr AltGr merged commit cb7a7fe into ocaml:master Jun 26, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dra27 dra27 deleted the dra27:gitattributes branch Jun 26, 2019
@rjbou rjbou added this to the 2.1.0 milestone Jun 26, 2019
@dra27

This comment has been minimized.

Copy link
Contributor Author

dra27 commented Aug 24, 2019

Could this be considered for 2.0.6?

@rjbou

This comment has been minimized.

Copy link
Collaborator

rjbou commented Aug 29, 2019

yup! Let's begin a 2.0.6 backported commits PR.

@rjbou rjbou mentioned this pull request Aug 30, 2019
@rjbou rjbou modified the milestones: 2.1.0, 2.0.6 Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.