Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further sanity checks #3934

Merged
merged 8 commits into from Jul 22, 2019
Merged

Further sanity checks #3934

merged 8 commits into from Jul 22, 2019

Conversation

@dra27
Copy link
Contributor

dra27 commented Jul 17, 2019

This brings #3929 to the 2.0 branch (checking install.sh is not strictly necessary, since it shouldn't be used from here, but it also pulls the infrastructure in). It then extends it with some more things from OCaml's CI to verify that configure is correctly committed.

@dra27

This comment has been minimized.

Copy link
Contributor Author

dra27 commented Jul 17, 2019

@dra27 dra27 force-pushed the dra27:sanity-2.0 branch from 87fc74e to b0a98a3 Jul 17, 2019
@dra27 dra27 force-pushed the dra27:sanity-2.0 branch from 98b6499 to 4a02ea1 Jul 17, 2019
@dra27

This comment has been minimized.

Copy link
Contributor Author

dra27 commented Jul 17, 2019

Right, that's better - I've switched the Travis CI image from Trusty to Xenial, which means it pulls in the correctly patched version of autoconf. We could use the same patch as OCaml, but it's ugly and I think that @AltGr, @rjbou and I are all using versions of autoconf which include that patch anyway.

@rjbou

This comment has been minimized.

Copy link
Collaborator

rjbou commented Jul 18, 2019

LGTM, thanks!

@dra27

This comment has been minimized.

Copy link
Contributor Author

dra27 commented Jul 18, 2019

Cool - I'll open the parallel branch for master

@AltGr AltGr merged commit 43eca21 into ocaml:2.0 Jul 22, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rjbou rjbou mentioned this pull request Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.