Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upopam export: record git commit hash when a git url is specified #4055
Conversation
This comment has been minimized.
This comment has been minimized.
|
Agree to integrate this sspecification, to be sure to rebuild the exact same switch. There is a side effect: I change pinned packages (and some from repo acceptiong allowing vcs urls): e;g if you pin a package to a branch, after an export & import this package will be pinned to an exact commit. There is a way to retrieve the commit branch (it's implemented in opam or a plugin), but we loose the information if first user wanted to pin to a commit or a branch. |
| let url' = OpamFile.URL.url url in | ||
| match url'.backend with | ||
| | `git -> | ||
| begin match OpamProcess.Job.run (OpamGit.VCS.revision (sd nv)) with |
This comment has been minimized.
This comment has been minimized.
| @@ -477,43 +477,98 @@ let import_t ?ask importfile t = | |||
| end; | |||
| t | |||
|
|
|||
| let read_overlays (read: package -> OpamFile.OPAM.t option) packages = | |||
| let read_overlays sd ~repos_roots (read: package -> OpamFile.OPAM.t option) packages = | |||
This comment has been minimized.
This comment has been minimized.
| let root = OpamStateConfig.(!r.root_dir) in | ||
| OpamSwitchState.with_ `Lock_none ~rt ~switch gt @@ fun st -> |
This comment has been minimized.
This comment has been minimized.
rjbou
Jan 10, 2020
Collaborator
To retrieve just the path, you don't need to load the switch state. You can get their sources paths wtth OpamPath.Switch (cf. OpamSwitch.source_dir, you already have the pinned and installed selections).
Plus, If you need to load the switch, better do add it as export argument, and from that you can access to repo state & global state (but it is always better to take state as argument).
Plus there is a lock on the switch (file) below.
| OpamSwitchCommand.export | ||
| OpamGlobalState.with_ `Lock_write @@ fun gt -> | ||
| OpamRepositoryState.with_ `Lock_none gt @@ fun rt -> | ||
| OpamSwitchCommand.export rt |
This comment has been minimized.
This comment has been minimized.
hannesm commentedJan 7, 2020
this is useful for having an export file which can be imported and will contain the exact same sources (related to #4040), part of reproducibilty efforts