Disentangle OpamProcess.resolve_command and OpamSystem.resolve_command
#5991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dra27
changed the title
OpamProcess.resolve_command and OpamSystem.resolve_commandOpamProcess.resolve_command and OpamSystem.resolve_command
kit-ty-kate
approved these changes
Jun 6, 2024
kit-ty-kate
approved these changes
Jun 6, 2024
rjbou
approved these changes
Jun 7, 2024
| let set_resolve_command = | ||
| let called = ref false in | ||
| fun resolve_command -> | ||
| if !called then invalid_arg "Just what do you think you're doing, Dave?"; |
Allow OpamStd.Sys to be have access to PATH-resolving machinery from OpamSystem. This also allows the dependency knot between OpamSystem and OpamProcess to be solved more simply.
Exposes the portion of OpamStd.Sys.resolve_command which searches the PATH environment for a given basename.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
opam initmenu overhaul wants to be able to useresolve_commandfrom withinOpamStd.Sys(to be used with some low-level functions), but this isn't possible at present because the default forOpamSystem.resolve_command's~envargument isOpamProcess.default_env.However, since #3348 there's already been a slightly unholy mess (added by me...) to allow OpamProcess to use
resolve_command. This PR disentagles it slightly, by moving the bulk of the logic toOpamStd.Sysand leaving the default argument handling inOpamProcessand then simply makingOpamSystem.resolve_commandan alias forOpamProcess.resolve_command. Not totally sure why I didn't do that in 2018...