Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be compatible with Cow ≥ 2.0.0 #147

Merged
merged 1 commit into from Nov 23, 2016
Merged

Conversation

Chris00
Copy link
Contributor

@Chris00 Chris00 commented Nov 21, 2016

Fixes #146

Other eyeballs looking at the changes would be useful as it is easy to miss something in the transformations.

Note: If mirage/ocaml-cow#99 got merged, some more changes will be necessary (but maybe for another release).

@AltGr
Copy link
Contributor

AltGr commented Nov 21, 2016

Oh, that's great, thanks for doing this!
According to Travis, it failed to build for some reason on 4.01 -- probably because it got cow 2.0.1 instead of 2.2.0 ?

+ ocamlfind ocamlc -c -bin-annot -g -annot -package cmdliner -package opamfu.cli -package opam-lib.client -package cow -package omd -package str -I apalog -o o2wPackage.cmo o2wPackage.ml
File "o2wPackage.ml", line 329, characters 13-24:
Error: Unbound value Html.strong
Did you mean string?

@Chris00
Copy link
Contributor Author

Chris00 commented Nov 21, 2016

I have added a constraint on Cow ≥ 2.2.0

@samoht
Copy link
Contributor

samoht commented Nov 23, 2016

LGTM, thanks!

@samoht samoht merged commit e9330dd into ocaml-opam:master Nov 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants