New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linker options for Xen/Mini-OS #231

Merged
merged 2 commits into from Dec 18, 2014

Conversation

Projects
None yet
3 participants
@talex5
Contributor

talex5 commented Dec 16, 2014

Note: depends on mirage/mirage-platform#111

@yallop

This comment has been minimized.

Show comment
Hide comment
@yallop

yallop Dec 16, 2014

Member

Thanks!

Is there an easy way to set up CI for ctypes on Xen/Mini-OS? It'd be useful to have some kind of automatic check to avoid inadvertently breaking the build.

Member

yallop commented Dec 16, 2014

Thanks!

Is there an easy way to set up CI for ctypes on Xen/Mini-OS? It'd be useful to have some kind of automatic check to avoid inadvertently breaking the build.

@talex5

This comment has been minimized.

Show comment
Hide comment
@talex5

talex5 Dec 17, 2014

Contributor

I've added some tests. Note however that they won't pass until the next mirage-platform release.

Contributor

talex5 commented Dec 17, 2014

I've added some tests. Note however that they won't pass until the next mirage-platform release.

@avsm

This comment has been minimized.

Show comment
Hide comment
@avsm

avsm Dec 17, 2014

Member

mirage-platform releases with this change now in ocaml/opam-repository#3219

Member

avsm commented Dec 17, 2014

mirage-platform releases with this change now in ocaml/opam-repository#3219

@yallop

This comment has been minimized.

Show comment
Hide comment
@yallop

yallop Dec 17, 2014

Member

The tests are passing on linux/4.01.0 now, but failing on osx (as expected, presumably).

Member

yallop commented Dec 17, 2014

The tests are passing on linux/4.01.0 now, but failing on osx (as expected, presumably).

@talex5

This comment has been minimized.

Show comment
Hide comment
@talex5

talex5 Dec 17, 2014

Contributor

I would have thought you should be able to install mirage-xen on OS X, but I don't have a machine to test it.

Contributor

talex5 commented Dec 17, 2014

I would have thought you should be able to install mirage-xen on OS X, but I don't have a machine to test it.

@avsm

This comment has been minimized.

Show comment
Hide comment
@avsm

avsm Dec 17, 2014

Member

mirage-xen wont compile on osx just yet due to the mirage-xen-minios dep

Member

avsm commented Dec 17, 2014

mirage-xen wont compile on osx just yet due to the mirage-xen-minios dep

@talex5

This comment has been minimized.

Show comment
Hide comment
@talex5

talex5 Dec 18, 2014

Contributor

I've updated the tests to check the Xen support only when mirage-xen is installable. This means that when more platforms are supported, the tests should run there too.

Contributor

talex5 commented Dec 18, 2014

I've updated the tests to check the Xen support only when mirage-xen is installable. This means that when more platforms are supported, the tests should run there too.

@yallop

This comment has been minimized.

Show comment
Hide comment
@yallop

yallop Dec 18, 2014

Member

Thanks, @talex5!

Member

yallop commented Dec 18, 2014

Thanks, @talex5!

yallop added a commit that referenced this pull request Dec 18, 2014

Merge pull request #231 from talex5/minios
Add linker options for Xen/Mini-OS

@yallop yallop merged commit 07c2ad5 into ocamllabs:master Dec 18, 2014

2 checks passed

continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci The Travis CI build passed
Details

@talex5 talex5 referenced this pull request Jan 17, 2015

Closed

Patches adding TLS support #52

14 of 14 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment