Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debian fixes #410

Merged
merged 4 commits into from Jun 24, 2016
Merged

Debian fixes #410

merged 4 commits into from Jun 24, 2016

Conversation

@glondu
Copy link
Contributor

@glondu glondu commented Jun 22, 2016

Hello,

Here is a branch that fixes compilation and tests on all Debian release architectures.

glondu added 3 commits Jun 22, 2016
Better delimit v's lifetime with a local block. This is relevant in
bytecode.
@@ -1,5 +1,6 @@
.SECONDEXPANSION:

BEST:=$(shell if which ocamlopt > /dev/null; then echo native; else echo byte; fi)

This comment has been minimized.

@yallop

yallop Jun 23, 2016
Contributor

Could the which be dropped here, like this:

BEST:=$(shell if ocamlopt > /dev/null; then echo native; else echo byte; fi)
?

Some systems, such as NixOS, apparently don't include which by default, and I'd rather avoid adding another opam dependency.

This comment has been minimized.

@glondu

glondu Jun 23, 2016
Author Contributor

In shell, it seems that the error message in case of a missing command is printed on stderr. So the following is better (tested with bash and dash):

BEST:=$(shell if ocamlopt > /dev/null 2>&1; then echo native; else echo byte; fi)

This comment has been minimized.

@yallop

yallop Jun 23, 2016
Contributor

That looks good to me!

@yallop
Copy link
Contributor

@yallop yallop commented Jun 24, 2016

Thank you!

@yallop yallop merged commit f7f4099 into ocamllabs:master Jun 24, 2016
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@glondu glondu deleted the glondu:debian-fixes branch Jun 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants