fix(config): resolve sparse_embedder provider from dict on MemoryConf…#917
Merged
Conversation
…ig deserialization When Memory is initialized with a dict config (e.g. from auto_config()), MemoryConfig coerced sparse_embedder dicts into BaseSparseEmbedderConfig, leaving _provider_name=None and all fields empty. Add a field_validator that resolves the correct provider subclass before Pydantic coercion. Fixes oceanbase#904
…ryConfig validation Without an explicit import of sparse_providers, BaseSparseEmbedderConfig._registry may be empty when MemoryConfig is first constructed (e.g. in isolated tests or partial imports), causing the field_validator to silently fall back to the base class instead of the correct provider subclass. Add side-effect import to guarantee the registry is filled before any MemoryConfig instance is created.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ig deserialization
When Memory is initialized with a dict config (e.g. from auto_config()), MemoryConfig coerced sparse_embedder dicts into BaseSparseEmbedderConfig, leaving _provider_name=None and all fields empty. Add a field_validator that resolves the correct provider subclass before Pydantic coercion.
Fixes #904