Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/project summary #27

Merged
merged 6 commits into from Oct 28, 2021
Merged

Conversation

TimDaub
Copy link
Collaborator

@TimDaub TimDaub commented Oct 21, 2021

Fixes #16

TODOs:

  • Create .sh that executes this script.
  • DAOBot should communicate some basic metrics: [Project Level, Times Proposed, Times Granted, Total Funded, Times Downvoted]
  • Create DAOBot script that populates [Project Summary] table

Resulting table demonstration: https://airtable.com/shr1eRtAZHL98cVc4

What I'm not doing because I don't have the permissions:

  • Create Notion page that further explains [Project Summary] table & specific columns.
  • Update wiki to link to Notion page.

@TimDaub TimDaub marked this pull request as ready for review October 21, 2021 14:49
"Project Summary" is now considered a pivot table of "All Proposals". To
update the records, we delete them all, re-summarize all proposals and
populate the "Project Summary" table with the updated information again.
@TimDaub
Copy link
Collaborator Author

TimDaub commented Oct 25, 2021

A resulting table that was generated with the script can be found here: https://airtable.com/shr1eRtAZHL98cVc4

@idiom-bytes
Copy link
Member

This is awesome Tim!
I'm going to point this out to the rest of the team so we can get this PR merged.

Thank you!

@TimDaub
Copy link
Collaborator Author

TimDaub commented Oct 25, 2021

A resulting table that was generated with the script can be found here: https://airtable.com/shr1eRtAZHL98cVc4

Actually, by browsing this table I saw that some numbers don't line up well. E.g it seems the "No" votes from R10 aren't added in the project summary. Maybe I should give this another look.

Also, on mobile it says "Unnamed record"
Screenshot_20211025-204517

@TimDaub
Copy link
Collaborator Author

TimDaub commented Oct 25, 2021

A resulting table that was generated with the script can be found here: https://airtable.com/shr1eRtAZHL98cVc4

Actually, by browsing this table I saw that some numbers don't line up well. E.g it seems the "No" votes from R10 aren't added in the project summary. Maybe I should give this another look.

Also, on mobile it says "Unnamed record"

I have now addressed this problem and it's not happening anymore. Here were my mistakes:

  • I had "used" an old "All proposals" table that didn't have the Round 10 results yet. I updated that table and now e.g. RPI also has roughly 2M down votes.
  • Additionally, the "Unnamed Record" issue, I was able to fix by making "Project Name" the primary field in air table. Now it's showing up correctly. See screenshot below:

signal-2021-10-25-232153_001

@TimDaub
Copy link
Collaborator Author

TimDaub commented Oct 25, 2021

Few more observations looking at the results table (https://airtable.com/shr1eRtAZHL98cVc4):

  • Project Coral doesn't show any "OCEAN Granted" and has in R2 "Not Granted" and in "OCEAN Granted" no value. Maybe this leads to the "OCEAN Granted" calculation trying to add undefined and a number hence the result becoming NaN. I'll have to look into that before we merge
  • Projects like "Middle East Community Building and Evangelism" don't show any values for "Voted Yes", "Voted No", "OCEAN Granted" because they failed the 500 OCEAN threshold. Shall we will the blank cells with zeros?

@TimDaub
Copy link
Collaborator Author

TimDaub commented Oct 28, 2021

Seeing all the other PRs accumulate, I wonder if it's possible that this PR gets merged and we address any eventual shortcomings in additional issues. Otherwise, I see some headaches from merge conflicts incoming.

@TimDaub
Copy link
Collaborator Author

TimDaub commented Oct 28, 2021

I just noticed I have merge privileges. OK here I go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create [Project Summary] table & related scripts.
2 participants